System.Uri: Updated logic for combining base and URL

[frobijn]

Description

• Updated implementation of Uri (Uri baseUri, string relativeUrl).
• Updated corresponding unit tests.
• Added .editorconfig.
• Unintended reformatting of the Uri (string, UriKind) and IsWellFormedUriString methods, probably because of tab/space conversion due to .editorconfig rules.

Motivation and Context

The previous implementation was based on conventions that are different from the regular rules for combining a base URL with a relative URL in browsers, as also implemented in the full .NET System.Uri. In particular (evaluated in C# interactive):

new Uri (new Uri ("http://localhost/Home/Sub"), "Other/Url").AbsoluteUri
    "http://localhost/Home/Other/Url" (old implementation: incorrect "http://localhost/Home/Sub/Other/Url")
 
new Uri (new Uri ("http://localhost/Home/Sub/"), "Other/Url").AbsoluteUri
    "http://localhost/Home/Sub/Other/Url" (old implementation: correct)

new Uri (new Uri ("http://localhost/Home/Sub.html?id=3"), "/Other/Page.html?code=x").AbsoluteUri
    "http://localhost/Other/Page.html?code=x" (old implementation: incorrect "http://localhost/Home/Sub.html?id=3/Other/Page.html?code=x")
     
new Uri (new Uri ("http://localhost/Home/Sub"), "/Other/Url").AbsoluteUri
    "http://localhost/Other/Url" (old implementation: incorrect "http://localhost/Home/Sub/Other/Url")

new Uri (new Uri ("http://localhost/Home/Sub"), "http://other/Other/Url").AbsoluteUri
    "http://other/Other/Url" (old implementation: not tested but incorrect)

How Has This Been Tested?

Updated unit tests.

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue with code or algorithm)
• New feature (non-breaking change which adds functionality to code)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dependencies (update dependencies and changes associated, has no impact on code or features)
• Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
• Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
• I have added new tests to cover my changes.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)

• .editorconfig is excluded by none and included by none
• Tests/HttpUnitTests/UriUnitTests.cs is excluded by none and included by none
• nanoFramework.System.Net.Http/Http/System.Uri.cs is excluded by none and included by none
• spelling_exclusion.dic is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[frobijn]

From the git history it seems that the old implementation was added by @Ellerbach. Ping because I presume the code was added to enable functionality in other applications. Those other applications may require an update if they rely on the old combination rules.

[Ellerbach]

OK, I see, that corrects more elements and correct some bugs I4ve been introducing correcting the previous bug. So all good as it's the proper behavior.

[Ellerbach]

Thanks for fixing the additional bugs. Seems that this time it's all god!

[Ellerbach]

azp /run

[josesimoes]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[josesimoes]

Aren't we better adding the above "tests" (in PR opening comment) in the combine constructor unit tests?

[frobijn]

Aren't we better adding the above "tests" (in PR opening comment) in the combine constructor unit tests?

I've updated the unit tests already. Or are you referring to other tests?

[josesimoes]

@frobijn you're right. I've overlooked the changes in the unit tests and mistook them for format fixes.
Those data rows include only complex and hard to read cases. We probably should have there a few ones with just simple cases (such as the ones you have above). But I suppose that can be added later.

[josesimoes]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[josesimoes]

LGTM

[josesimoes]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).