Merged
Conversation
subtypeの一律除外からホワイトリスト方式に変更し、 file_share, me_message, thread_broadcastを転送対象とした。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
CloudWatchログで検知した file_share 等の取りこぼしに対して、転送対象subtypeを明確にホワイトリスト化し、テストも追加している点が良い改善です。Slackのmessage subtype仕様に沿って、転送判定の意図がコード上でも読み取りやすくなっています。
Changes:
messageFilter.tsのsubtype判定をホワイトリスト方式に変更し、undefined / file_share / me_message / thread_broadcastを転送対象に追加- subtypeの意図をJSDocで明示（Slack APIドキュメントへのリンク含む）
- 追加subtypeと未知subtypeに対するユニットテストを拡充
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/messageFilter.ts | 転送対象subtypeをSetでホワイトリスト化し、file_share等を転送対象に含める |
| src/lib/tests/messageFilter.test.ts | ホワイトリスト化に合わせてテスト文言を更新し、追加subtype/未知subtypeのテストを追加 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
なし（CloudWatchログ調査で発見）
変更内容
file_share,me_message,thread_broadcastのメッセージが転送されていなかったのを修正確認したこと
file_shareがskipped: not forwardableになっていることを確認スクリーンショット
なし
補足事項
なし
PR時のセルフチェック
by