fix(web): paint the app shell and auth layout with the canvas token - #81
Merged
Merged
Conversation
Both page shells used `bg-background`, which the @Nebari theme resolves to zinc-50 (the header layer), so the body rendered light gray. The registry's page layer is `--canvas` (white in light, zinc-975 in dark), and the skill documents `--background` as a legacy alias to avoid for page shells. Follow-up to #80 / nebari-dev/nebari-design#143. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
jbouder
added a commit
that referenced
this pull request
Sep 4, 2026
Resolves conflicts with #80 (registry re-sync) and #81 (canvas token): - components/ui/{dialog,input,select,textarea}.tsx and ui-primitives.test.tsx take main's registry copies. - App-owned dialogs, DocMetadataHeader, FramePicker, AdminMembersPage and FrameDetailPage keep this branch's Base UI compositions; VersionHistory and SlotSection stay deleted. - styles.css takes main's @nebari/theme layout plus this branch's typography plugin, border-color reset and prose code rule. The white --background override is dropped now that the shell paints with --canvas. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppShellandAuthLayoutusedbg-background, which the@nebari/themetokens synced in #80 resolve to zinc-50 (the same value as the header layer), so the app body rendered light gray instead of white.The registry's page layer is
--canvas(white in light mode, zinc-975 in dark), and thenebari-uiskill documents--backgroundas a legacy alias that page shells should not use. This swaps both shells tobg-canvas. Component-levelbg-backgroundfills (picker popup, catalog toggle) are intentionally unchanged.Follow-up to #80, part of nebari-dev/nebari-design#143.
Verification
npm run lint— 0 errors (13 pre-existing warnings on registry files)npm run typecheck— passnpm test— 43 files, 149 tests passnpm run build— pass🤖 Generated with Claude Code