support connection strings that use our workarounds for libpg connections#186
Draft
conradludgate wants to merge 1 commit intomainfrom
Draft
support connection strings that use our workarounds for libpg connections#186conradludgate wants to merge 1 commit intomainfrom
conradludgate wants to merge 1 commit intomainfrom
Conversation
conradludgate
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For libpq protocol connections, we have some workarounds when SNI is not available: https://neon.com/docs/connect/connection-errors#the-endpoint-id-is-not-specified. They're also sometimes used for PrivateLink connections when the customer doesn't want to enable the Private DNS.
For example, instead of using
They might instead use
This PR allows those URLs to work with the serverless driver when using sql-over-http.
Unfortunately this doesn't work well due to TLS. The name returned by Neon certificates will not match the DNS, so it's not as seamless as one would hope, it still requires the code to update to set a new fetch function that can support custom TLS verifiers.
ref: https://databricks.atlassian.net/browse/LKB-7703