[DoNotMerge] DBus proof-of-concept#533
Open
EmilienKia wants to merge 18 commits intonetworkupstools:masterfrom
Open
[DoNotMerge] DBus proof-of-concept#533EmilienKia wants to merge 18 commits intonetworkupstools:masterfrom
EmilienKia wants to merge 18 commits intonetworkupstools:masterfrom
Conversation
Member
|
Per Travis, |
Contributor
Author
|
Hello Jim, |
Member
|
@EmilienKia : Some merge conflicts cropped up while this PR was waiting, the Makefile one is trivial, but the one in code wants you to revise what is right :) |
Not complete yet. Only integrate introspect, get and getall. No building chain complete integration yet.
Use upsdebugx and upslogx for logging. Add return code for tracing errors. Release dbus allocated memory in case of error.
Tested on Ubuntu 16.04 derivate (Linux Mint 18.3). Should be tested on other systems and particularly for default dir (/etc/dbus-1/system.d/).
Member
|
@EmilienKia : thanks for the code resync bump; as for the content of feature set you intended to have, is this still a "DoNotMerge"? ;) |
Member
|
@EmilienKia : probably the master branch evolved since you branched for this PoC; there are complaints about inconsistencies in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is a not-ready-to-merge proof-of-concept of DBus integration of NUT, just to add some views about #526.
It only have Get/GetAll/Set introspection for devices. It does not support notifications yet but it is a good starting point for discussions.
I will add notification for status soon.
Please test but don't merge it. It is not integrated to autoconf feature detection. Some security configuration files could be required by some distributions (.conf in /etc/dbus-1/system.d). Moreover no performance nor leak detection have been done.
Enjoy,
Emilien