fix(shared search): remove duplicate entries

[ZetaTom]

This change addresses an issue where files would be duplicated in the Shared tab under certain conditions.

Steps to reproduce

1. Set up Nextcloud user account and create multiple shares
2. Checkout branch of pull request
3. Apply the diff below (Diff for testing)
   • not strictly required; bypasses early exit
4. Build Nextcloud app and sign in
5. Open Shared tab
6. Check if there are any duplicate entries present
   • compare to master branch

Diff for testing

diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/OCShareToOCFileConverter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/OCShareToOCFileConverter.kt
index fd17de1605..f56fffd58f 100644
--- a/app/src/main/java/com/owncloud/android/ui/adapter/OCShareToOCFileConverter.kt
+++ b/app/src/main/java/com/owncloud/android/ui/adapter/OCShareToOCFileConverter.kt
@@ -59,9 +59,7 @@ object OCShareToOCFileConverter {
             return@withContext emptyList()
         }
 
-        val newShares = shares.filter { share ->
-            cachedFiles.none { file -> file.decryptedRemotePath == share.path }
-        }
+        val newShares = shares
 
         if (newShares.isEmpty()) {
             return@withContext cachedFiles

Screenshots

Current Version on master	This Pull Request

---

• Tests written, or not not needed

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16382.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	74	74
Dodgy code	260	260
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	43	43
Security	18	18
Total	483	483

[alperozturk96]

/backport to stable-3.35