Skip to content

chore: test upload of a locked file inside a remote deleted folder#9336

Merged
mgallien merged 3 commits intomasterfrom
bugfix/uploadLockedFileInDeletedFolder
Feb 26, 2026
Merged

chore: test upload of a locked file inside a remote deleted folder#9336
mgallien merged 3 commits intomasterfrom
bugfix/uploadLockedFileInDeletedFolder

Conversation

@mgallien
Copy link
Collaborator

No description provided.

@mgallien mgallien self-assigned this Jan 20, 2026
@mgallien mgallien added this to the 33.0.0 milestone Jan 21, 2026
@mgallien mgallien force-pushed the bugfix/uploadLockedFileInDeletedFolder branch from 8053b22 to bde3d74 Compare January 23, 2026 13:52
@mgallien mgallien marked this pull request as ready for review January 26, 2026 15:47
@mgallien mgallien force-pushed the bugfix/uploadLockedFileInDeletedFolder branch 2 times, most recently from 7974c13 to 6297be8 Compare January 28, 2026 14:05
@mgallien mgallien force-pushed the bugfix/uploadLockedFileInDeletedFolder branch from 6297be8 to a423813 Compare February 24, 2026 21:09
@mgallien mgallien force-pushed the bugfix/uploadLockedFileInDeletedFolder branch from a423813 to 75a1df5 Compare February 25, 2026 16:32
@mgallien mgallien requested a review from nilsding February 25, 2026 16:33
@mgallien mgallien force-pushed the bugfix/uploadLockedFileInDeletedFolder branch from 75a1df5 to 96510f2 Compare February 25, 2026 18:13
@mgallien mgallien enabled auto-merge February 25, 2026 18:13
@mgallien mgallien force-pushed the bugfix/uploadLockedFileInDeletedFolder branch 2 times, most recently from f03b732 to 4b19765 Compare February 26, 2026 08:35
@mgallien mgallien force-pushed the bugfix/uploadLockedFileInDeletedFolder branch from 4b19765 to 1361094 Compare February 26, 2026 13:23
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
no matter what a job should not exists inside a deleted folder:
 * the folder will be deleted before any uploads
 * there is no guarantee that a rename would also be executed before
 * there is no point in downloading a new file inside a deleted folder

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nilsding nilsding force-pushed the bugfix/uploadLockedFileInDeletedFolder branch from 1361094 to 6c263bb Compare February 26, 2026 18:55
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9336.zip

Digest: sha256:d5147d58418687f0b32270224dfecdd73af2653c62b31519cff013d7560d359a

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
48 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 4ea91c5 into master Feb 26, 2026
23 of 24 checks passed
@mgallien mgallien deleted the bugfix/uploadLockedFileInDeletedFolder branch February 26, 2026 19:55
@nilsding
Copy link
Member

/backport to stable-33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants