Chore/remove compilation warning qt 6.10

.github/workflows/clang-tidy-review.yml

@@ -9,7 +9,7 @@ on:
 jobs:
   clang-tidy:
     runs-on: ubuntu-latest
-    container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-forky-6.9.2-3
+    container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-sid-6.10.2-1
     steps:
     - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       with:

.github/workflows/linux-clang-compile-tests.yml

@@ -8,7 +8,7 @@ jobs:
   build:
     name: Linux Clang compilation and tests
     runs-on: ubuntu-latest
-    container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-forky-6.9.2-3
+    container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-sid-6.10.2-1
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:

.github/workflows/linux-gcc-compile-tests.yml

@@ -8,7 +8,7 @@ jobs:
   build:
     name: Linux GCC compilation and tests
     runs-on: ubuntu-latest
-    container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-forky-6.9.2-3
+    container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-sid-6.10.2-1
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:

.github/workflows/sonarcloud.yml

@@ -8,7 +8,7 @@ jobs:
   build:
     name: SonarCloud analysis
     runs-on: [ubuntu-latest, self-hosted]
-    container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-forky-6.9.2-3
+    container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-sid-6.10.2-1
     env:
       SONAR_SERVER_URL: "https://sonarcloud.io"
       BUILD_WRAPPER_OUT_DIR: build_wrapper_output_directory # Directory where build-wrapper output will be placed

src/gui/folderwatcher.cpp

@@ -113,8 +113,8 @@ void FolderWatcher::performSetPermissionsTest(const QString &path)
 
     if (!QFile::exists(path)) {
         QFile f(path);
-        f.open(QIODevice::WriteOnly);
-        if (!f.isOpen()) {
+        const auto openResult = f.open(QIODevice::WriteOnly);
+        if (!openResult || !f.isOpen()) {
             qCWarning(lcFolderWatcher()) << "Failed to create test file: " << path;
             return;
         }
@@ -158,7 +158,11 @@ void FolderWatcher::startNotificationTestWhenReady()
         FileSystem::setModTime(path, mtime + 1);
     } else {
         QFile f(path);
-        f.open(QIODevice::WriteOnly | QIODevice::Append);
+        const auto openResult = f.open(QIODevice::WriteOnly | QIODevice::Append);
+        if (!openResult || !f.isOpen()) {
+            qCWarning(lcFolderWatcher()) << "Failed to create test file: " << path;
+            return;
+        }
     }
     FileSystem::setFileHidden(path, true);
 

src/gui/syncrunfilelog.cpp

@@ -1,10 +1,10 @@
 /*
  * SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2014 ownCloud GmbH
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include <QRegularExpression>
 
 #include "syncrunfilelog.h"
 #include "common/utility.h"
@@ -37,7 +37,10 @@
     while (FileSystem::fileExists(filename)) {
 
         QFile file(filename);
-        file.open(QIODevice::ReadOnly| QIODevice::Text);
+        const auto openResult = file.open(QIODevice::ReadOnly| QIODevice::Text);
+        if (!openResult) {
+            qWarning() << "error while opening the file" << filename;
+        }
         QTextStream in(&file);
         QString line = in.readLine();
 
@@ -66,7 +69,10 @@
     }
     _file.reset(new QFile(filename));
 
-    _file->open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text);
+    const auto openResult = _file->open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text);
+    if (!openResult) {
+        qWarning() << "error while opening the file" << filename;
+    }
     _out.setDevice(_file.data());
 
 

src/gui/updater/ocupdater.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include "theme.h"
 #include "configfile.h"
 #include "common/utility.h"
 #include "accessmanager.h"
@@ -400,7 +400,10 @@
                     setDownloadState(Downloading);
                     _file.reset(new QTemporaryFile);
                     _file->setAutoRemove(true);
-                    _file->open();
+                    const auto openResult = _file->open();
+                    if (!openResult) {
+                        qCWarning(lcUpdater()) << "error while opening the temporary file";
+                    }
                 }
             }
         }

src/gui/wizard/owncloudsetuppage.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include <QDir>
 #include <QFileDialog>
 #include <QUrl>
 #include <QTimer>
@@ -411,7 +411,11 @@
 void OwncloudSetupPage::slotCertificateAccepted()
 {
     QFile certFile(addCertDial->getCertificatePath());
-    certFile.open(QFile::ReadOnly);
+    const auto openResult = certFile.open(QFile::ReadOnly);
+    if (!openResult) {
+        qWarning() << "Failed to open certificate file:" << addCertDial->getCertificatePath();
+        return;
+    }
     QByteArray certData = certFile.readAll();
     QByteArray certPassword = addCertDial->getCertificatePasswd().toLocal8Bit();
 

src/libsync/clientsideencryption.cpp

@@ -2488,8 +2488,17 @@ bool EncryptionHelper::fileEncryption(const QByteArray &key, const QByteArray &i
 bool EncryptionHelper::fileDecryption(const QByteArray &key, const QByteArray& iv,
                                       QFile *input, QFile *output)
 {
-    input->open(QIODevice::ReadOnly);
-    output->open(QIODevice::WriteOnly);
+    const auto inputOpenResult = input->open(QIODevice::ReadOnly);
+    if (!inputOpenResult) {
+        qCWarning(lcCse()) << "Failed to open input file";
+        return false;
+    }
+
+    const auto outputOpenResult = output->open(QIODevice::WriteOnly);
+    if (!outputOpenResult) {
+        qCWarning(lcCse()) << "Failed to open output file";
+        return false;
+    }
 
     // Init
     CipherCtx ctx;

test/syncenginetestutils.cpp

@@ -71,7 +71,10 @@ void DiskFileModifier::insert(const QString &relativePath, qint64 size, char con
     if (!file.exists()) {
         QVERIFY(!file.exists());
     }
-    file.open(QFile::WriteOnly);
+    const auto openResult = file.open(QFile::WriteOnly);
+    if (!openResult) {
+        qWarning() << "error while opening the file" << relativePath << _rootDir.filePath(relativePath);
+    }
     QByteArray buf(1024, contentChar);
     for (int x = 0; x < size / buf.size(); ++x) {
         file.write(buf);
@@ -90,15 +93,21 @@ void DiskFileModifier::setContents(const QString &relativePath, char contentChar
     QFile file { _rootDir.filePath(relativePath) };
     QVERIFY(file.exists());
     qint64 size = file.size();
-    file.open(QFile::WriteOnly);
+    const auto openResult = file.open(QFile::WriteOnly);
+    if (!openResult) {
+        qWarning() << "error while opening the file" << relativePath << _rootDir.filePath(relativePath);
+    }
     file.write(QByteArray {}.fill(contentChar, size));
 }
 
 void DiskFileModifier::appendByte(const QString &relativePath)
 {
     QFile file { _rootDir.filePath(relativePath) };
     QVERIFY(file.exists());
-    file.open(QFile::ReadWrite);
+    const auto openResult = file.open(QFile::ReadWrite);
+    if (!openResult) {
+        qWarning() << "error while opening the file" << relativePath << _rootDir.filePath(relativePath);
+    }
     QByteArray contents = file.read(1);
     file.seek(file.size());
     file.write(contents);
@@ -1455,7 +1464,10 @@ void FakeFolder::toDisk(QDir &dir, const FileInfo &templateFi)
             toDisk(subDir, child);
         } else {
             QFile file { dir.filePath(child.name) };
-            file.open(QFile::WriteOnly);
+            const auto openResult = file.open(QFile::WriteOnly);
+            if (!openResult) {
+                qWarning() << "error while opening the file" << child.name << dir.filePath(child.name);
+            }
             file.write(QByteArray {}.fill(child.contentChar, child.size));
             file.close();
             OCC::FileSystem::setModTime(file.fileName(), OCC::Utility::qDateTimeToTime_t(child.lastModified));
@@ -1474,7 +1486,10 @@ void FakeFolder::fromDisk(QDir &dir, FileInfo &templateFi)
             fromDisk(subDir, subFi);
         } else {
             QFile f { diskChild.filePath() };
-            f.open(QFile::ReadOnly);
+            const auto openResult = f.open(QFile::ReadOnly);
+            if (!openResult) {
+                qWarning() << "error while opening the file" << diskChild.filePath();
+            }
             auto content = f.read(1);
             if (content.size() == 0) {
                 qWarning() << "Empty file at:" << diskChild.filePath();

test/testfolderman.cpp

@@ -8,7 +8,7 @@
  * any purpose.
  */
 
 #include <qglobal.h>
 #include <QTemporaryDir>
 #include <QtTest>
 
@@ -281,7 +281,11 @@
         QVERIFY(dir2.mkpath("free2/sub"));
         {
             QFile f(dir.path() + "/sub/file.txt");
-            f.open(QFile::WriteOnly);
+            const auto openResult = f.open(QFile::WriteOnly);
+            if (!openResult) {
+                qWarning() << "Failed to create file:" << dir.path() + "/sub/file.txt";
+                return;
+            }
             f.write("hello");
         }
         QString dirPath = dir2.canonicalPath();

test/testlockfile.cpp

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include "lockfilejobs.h"
 
 #include "account.h"
 #include "accountstate.h"
@@ -938,7 +938,11 @@
         QVERIFY(fakeFolder.syncJournal().setFileRecord(record));
         qDebug() << fakeFolder.localPath() + u"parent/child/.~lock.hello.odt#"_s;
         QFile newLockFile(fakeFolder.localPath() + u"parent/child/.~lock.hello.odt#"_s);
-        newLockFile.open(QFile::OpenModeFlag::NewOnly);
+        const auto openResult = newLockFile.open(QFile::OpenModeFlag::NewOnly);
+        if (!openResult) {
+            qWarning() << "Failed to create lock file:" << fakeFolder.localPath() + u"parent/child/.~lock.hello.odt#"_s;
+            return;
+        }
         OCC::FileSystem::setFileHidden(fakeFolder.localPath() + u"parent/child/.~lock.hello.odt#"_s, true);
 
         fakeFolder.remoteModifier().remove(u"parent/child"_s);