-
Notifications
You must be signed in to change notification settings - Fork 295
fix: action items icons on compact mode #12255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: greta <[email protected]>
|
I forgot to change the icon-spam |
nimishavijay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! Good point about it being first, I don't have a strong opinion about this. However 2 other points:
- could we change the colour of the important icon to primary? Before their positions were very different so it was easy to see distinguish between them, but since both are basically in the same position it is difficult to tell if a message is marked as favourite or important
- before these buttons used to be clickable, is that still the case? If so it seems like the clickable area is very small. The size of the icons can also be increased to 16px or even 18px because they seem very small now.
This is a customized icon, and we would need a new file for that, which is doable, but i would say in this case it is maybe unnecessary, because I think we should have the same icon everywhere for the same action. For example, Talk for me is a bit off. When in compact mode, the favorite icon changes color to gray, and i keep clicking it to mark it as favorite when it is actually favorited. Also, in our case, if i have the primary colour on the list, and then i click that message, it will be yellow again in the avatar of thread. So visually it would create a confusion, i think.
Yes, they are clickable, and i can make it bigger. |
I would be ok with having it blue even in the avatar of the thread, with a thin border of --color-main-background, so we don't beed 2 files just one where the important icon is blue everywhere to better distinguish them. In the current version if there is only one icon I cannot tell without my glasses if it's favourite or important, especially because they are quite small and the color contrast is also quite low.
Makes sense! It can be 20px icons (as there is more space) before the sender details. |

@nimishavijay In your mockup, the important icon is second. Since we have the important icon first in the avatar, I thought to do the same here.
If you have a strong opinion on that, I'm happy to change the order