Skip to content

fix(provisioning): prevent silent save failure around master user #13076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tnxfi wants to merge 1 commit into
base: local-add-masteruser
Choose a base branch
from
+23 −2
Open

fix(provisioning): prevent silent save failure around master user #13076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/components/settings/ProvisioningSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,12 @@
<div v-show="masterPasswordEnabled">
<div>
<input
id="mail-master-password"
:id="'mail-master-password' + setting.id"
v-model="masterPassword"
:disabled="loading"
type="password"
:required="masterPasswordEnabled">
<label for="mail-master-password"> {{ t('mail', 'Master password') }} </label>
<label :for="'mail-master-password' + setting.id"> {{ t('mail', 'Master password') }} </label>
</div>
<p>
{{ t('mail', 'When only master password is set, all users will authenticate with their normal username and this static password.') }}
Expand Down Expand Up @@ -513,6 +513,27 @@ export default {
},
},

watch: {
masterPasswordEnabled(enabled) {
if (!enabled) {
// Master user/separator only apply together with the master
// password. Clear them when it is disabled so a value that is
// now hidden cannot silently block or alter the saved config.
this.masterUser = ''
this.masterUserSeparator = ''
}
},

masterUser(user) {
// Default to the Dovecot master-user separator so the separator
// field is never required-but-empty (which made saving fail
// without any visible feedback).
if (user.length > 0 && this.masterUserSeparator === '') {
this.masterUserSeparator = '*'
}
},
},

beforeMount() {
logger.debug('provisioning setting loaded', { setting: this.setting })
},
Expand Down