V1.6.0 nextcloud 31

[umgfoin]

Prepare release 1.6.0

[umgfoin]

@tacruc, FYI: 'was following your conversations with Mr. Copilot with great interest. A fix for the problematic assignment-operator in FavoritesController is part of this PR.

Can you give me a hint how to fix CI

• PHP needs to be a minimum version of PHP 7.4.0 and maximum version of PHP 8.3.*.
• Error: Cannot find module 'node:child_process'
• npm ERR! Cannot read property '@fortawesome/fontawesome-free' of undefined
  Solved: Fixed with npm i --lockfile-version 2 --package-lock-only

I'm able to build the project locally without dep. child_process.

Concerning PR #1223 / your branch (HEIC-support):
Upstream discussions seem to vote for underlying support in PHP 8.5, so this should probably be still postponed.

[tacruc]

Hi @umgfoin,
Thank you very much for your contribution. I will give my best to give you some more detailed Feedback and help over the weekend.

did you check if the map was loading and working after:

• Update @raruto/leaflet-elevation: 1.9.6 -> 2.5.1
  In my previous attempts this update broke the UI and I didn't manage in reasonable time to fix it.

Are you reachable on talk.nextcloud.com or some other IM?

[umgfoin]

Hi,

did you check if the map was loading and working after:

* Update @raruto/leaflet-elevation: 1.9.6 -> 2.5.1
  In my previous attempts this update broke the UI and I didn't manage in reasonable time to fix it.

Yes, seems to load and work correctly (subjectively with slightly slower tile loading than 1.9.6) except of the watercolor map.
During testing, I had comparable issues, too - they were amongst others related to broken dependency maps/ package-lock-json etc.). A solution was, to completely remove and re-install (npm) entire packages (not limited to @raruto/leaflet-elevation).
Webpack is complaining (warn) about dynamic d3 imports. I had to remove the static d3-import in Maps.vue.
Not sure, if this is a viable solution?

Are you reachable on talk.nextcloud.com or some other IM?

I'll send you my contact to your github-mail.
++umgfoin.

[umgfoin]

@raruto/leaflet-elevation: 1.9.6 -> 2.5.1
In order to make the elevation-control work correctly with newly introduced "dynamic" imports (since 2.0.0), I had to find a solution to lineup webpack-"linking" and runtime-linking. It ended up in overloading the control's import-methods at runtime aka "monkey-patching". I'm not really happy about this approach.
However, this might be a solution to get rid of other dynamically loaded imports which are imported even in 1.9.6 version from external (unpkg.com). It seems as Julien Veyssier unsuccessfully tried to avoid this originally, when introducing leaflet-elevation.

[umgfoin]

npm ci still faiiing with:

> @nextcloud/webpack-vue-config@6.3.0 postinstall /home/runner/work/maps/maps/node_modules/@nextcloud/webpack-vue-config
> node ./scripts/postinstall.js

internal/modules/cjs/loader.js:818
  throw err;
  ^

Error: Cannot find module 'node:child_process'

module child_process is installed in dev-section

[flabbamann]

Hi @umgfoin,
I'm not sure if this relates to your problem, as I don't know much about node 😉, but package.json specifies minimum node version 20, and CI runs with node 12.

maps/.github/workflows/test.yml

Line 66 in afbb0d8

node-version: 12.x

[umgfoin]

but package.json specifies minimum node version 20, and CI runs with node 12.

Many thanks, @flabbamann: This was the culprit!
In particular:
Updated dep @nextcloud/webpack-vue-config: 6.3.0' uses a postinstall script refering to node:child_process in a require-call. The namespace-notation node:xxx is supported not earlier than node >=16.7 ...

"ALL checks have passed"

[tacruc]

Thanks alot