Skip to content

fix: Fix alignment issues of app password form#53123

Closed
sandicej wants to merge 0 commit into
nextcloud:masterfrom
sandicej:master
Closed

fix: Fix alignment issues of app password form#53123
sandicej wants to merge 0 commit into
nextcloud:masterfrom
sandicej:master

Conversation

@sandicej

Copy link
Copy Markdown

Summary

Set form max-width to 400px for consistency with other settings forms.
Moved "Create new app password" to a new line to align with the styling of other forms.


Before fix:
image

After fix:
image

Checklist

@sandicej sandicej requested a review from a team as a code owner May 26, 2025 23:34
@sandicej sandicej requested review from artonge, nfebe and sorbaugh and removed request for a team May 26, 2025 23:34
@artonge artonge requested a review from marcoambrosini May 27, 2025 09:58
@AndyScherzinger AndyScherzinger added design Design, UI, UX, etc. 3. to review Waiting for reviews labels May 28, 2025
@joshtrichards joshtrichards requested a review from susnux May 30, 2025 14:23
@joshtrichards

Copy link
Copy Markdown
Member

/compile

}

.row {
#generate-app-token-section {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you removed the styling for the classes row and spacing, please also remove the class from the element.

@marcoambrosini marcoambrosini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sandicej, thanks for your contribution :)

I think it would be better to just fix the vertical alignment of the button here, without moving the submit button to a new line.
The current with of the table is more than 400px, but I agree with your idea of equalizing the with of the new-app-password-form to it.

Screenshot 2025-06-04 at 15 43 05

That said, what do you think about setting the with of these elements at 900px, like many other other settings elements? Something like this:

Screenshot 2025-06-04 at 15 48 44

I think it would also make sense to create a css variable --settings-width for this, but that's probably for another pr :)

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@sandicej

sandicej commented Jun 17, 2025

Copy link
Copy Markdown
Author

Hi @marcoambrosini,

thank you for the feedback.

I'm fine with the proposed fix.
There are a couple of points I'd like to clarify:


  1. The "App name" field will have a variable width depending on the length of already added app names.
    image
    image

  1. On mobile, the button currently takes up most of the available space. I think it might be better to wrap it to a new line when the field width drops below 50% of the row width.
    image
    image

Please let me know if these points sound reasonable to you.

@marcoambrosini

Copy link
Copy Markdown
Member

Hi @sandicej,

  1. I think the app name field should be of fixed width regardless of the length of the app name itself. If it overflows, we ellipsize.
  2. It's fine to wrap on mobile for sure!

Thanks again :)

@sandicej

Copy link
Copy Markdown
Author

Hi @marcoambrosini,

Thanks for the feedback! I've applied the requested changes:

  • Set the form width to 900px as suggested.
  • The "Create new app password" button now wraps to a new line when its width drops below 50%

I haven’t introduced a --settings-width CSS variable at this stage, but I agree it's a good idea for a future PR

Let me know if there's anything else you'd like me to adjust!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 1, 2025
@susnux susnux added the community pull requests from community label Jun 9, 2026
@susnux

susnux commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Due to the branch name conflict (it was not a proper branch but just a PR from "master") I failed to properly rebase the branch.
Copy in #61186

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug community pull requests from community design Design, UI, UX, etc. feature: authentication feature: settings feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Alignment issues of app password form

6 participants