perf: Optimize deleting the list of invalid shares#60660
Open
CarlSchwan wants to merge 1 commit into
Open
Conversation
CarlSchwan
added
the
♻️ refactor
CarlSchwan
requested review from
Altahrim,
leftybournes,
provokateurin and
salmart-dev
CarlSchwan
force-pushed
the
carl/report-invalid-shares-impro
branch
from
9331c8f to
4d32706
Compare
And make the code a bit easier to read. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/report-invalid-shares-impro
branch
from
4d32706 to
f5b94b9
Compare
| $deletedInLastChunk = self::CHUNK_SIZE; | ||
| while ($deletedInLastChunk === self::CHUNK_SIZE) { | ||
| $deletedInLastChunk = 0; | ||
| while (true) { | ||
| $result = $query->executeQuery(); |
Member
There was a problem hiding this comment.
The parameter isn't set on the first invocation, so this will fail, no?
Member
Author
There was a problem hiding this comment.
this is a different query there is two $query with a limit of 1000 and $deleteQuery which then delete the results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
And make the code a bit easier to read.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)