test(files): migrate copy/move e2e from Cypress to Playwright#61165
Open
pringelmann wants to merge 2 commits into
Open
test(files): migrate copy/move e2e from Cypress to Playwright#61165pringelmann wants to merge 2 commits into
pringelmann wants to merge 2 commits into
Conversation
pringelmann
commented
Jun 10, 2026
pringelmann
commented
Jun 10, 2026
| const response = await request.fetch(davUrl(user, parentPath), { | ||
| method: 'PROPFIND', | ||
| headers: { requesttoken, Depth: '1' }, | ||
| data: '<?xml version="1.0"?><d:propfind xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns"><d:prop><oc:permissions/></d:prop></d:propfind>', |
Contributor
Author
There was a problem hiding this comment.
Got Claude to help me with this part, but I'm still learning WebDAV so cannot easily judge if this is good. Would appreciate feedback.
pringelmann
commented
Jun 10, 2026
| baseURL, | ||
| // send: 'always' — the OCS API doesn't issue a Basic auth challenge, so | ||
| // credentials must be sent preemptively (DAV would challenge, OCS won't) | ||
| httpCredentials: { username: owner.userId, password: owner.password, send: 'always' }, |
Contributor
Author
There was a problem hiding this comment.
Since this is a once-off API seeding action, I decided to keep it simple and use http auth. (as opposed to creating a context for the second user)
Happy to debate
pringelmann
force-pushed
the
test/migrate-files-copy-move-playwright
branch
from
bcea929 to
92ca014
Compare
pringelmann
requested review from
artonge,
nfebe,
sorbaugh and
susnux
and removed request for
a team
pringelmann
force-pushed
the
test/migrate-files-copy-move-playwright
branch
from
92ca014 to
0150af1
Compare
susnux
approved these changes
Jun 11, 2026
susnux
requested changes
Jun 11, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
test/migrate-files-copy-move-playwright
branch
from
cd0bf3f to
7bfe733
Compare
susnux
approved these changes
Jun 11, 2026
7 tasks
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
test/migrate-files-copy-move-playwright
branch
from
7bfe733 to
8ddc72f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the
filesandfiles_sharingcopy/move specs. Adds aCopyMoveDialogPagefile-picker section, an OCS share helper, and an owner/recipient fixture for the sharing cases.NOTE: The sharing "move without delete permission" case is omitted: the recipient's permission view propagates too inconsistently to assert reliably (the cypress original was flaky for the same reason). Noted for a follow-up PR.
Checklist
AI (if applicable)