feat(TaskProcessing): Update completionExpectedAt in Manager#setTaskProgress#61190
Open
marcelklehr wants to merge 1 commit into
Open
feat(TaskProcessing): Update completionExpectedAt in Manager#setTaskProgress#61190marcelklehr wants to merge 1 commit into
marcelklehr wants to merge 1 commit into
Conversation
…rogress Assisted-by: ClaudeCode:claopus-4-7 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
kyteinsky
reviewed
Jun 12, 2026
| // We need a positive elapsed time and a positive progress to avoid divide-by-zero | ||
| // and the wildly unstable estimates produced when progress is still near zero. | ||
| $startedAt = $task->getStartedAt(); | ||
| if ($startedAt !== null && $progress > 0.0) { |
Contributor
There was a problem hiding this comment.
should we also verify if $progress <= 1.0, even before the setProgress() call?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
3. to review, feature component)stable32)AI (if applicable)