Skip to content

feat(message-expiry): Add message expiry msg on the right side bar#16690

Merged
Antreesy merged 1 commit intonextcloud:mainfrom
existentialcoder:iss-16659
Jan 23, 2026
Merged

feat(message-expiry): Add message expiry msg on the right side bar#16690
Antreesy merged 1 commit intonextcloud:mainfrom
existentialcoder:iss-16659

Conversation

@existentialcoder
Copy link
Copy Markdown
Contributor

@existentialcoder existentialcoder commented Jan 8, 2026 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Personal
image
Group
image |

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

nickvergessen
nickvergessen reviewed Jan 8, 2026
View reviewed changes
Comment thread l10n/en_GB.json Outdated
nickvergessen
nickvergessen reviewed Jan 8, 2026
View reviewed changes
Comment thread src/components/RightSidebar/RightSidebar.vue Outdated
Comment thread src/components/RightSidebar/RightSidebar.vue Outdated
@existentialcoder existentialcoder changed the title Iss 16659 feat(message-expiry): Add message expiry msg on the right side bar Jan 8, 2026
Antreesy
Antreesy reviewed Jan 9, 2026
View reviewed changes
Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
Comment thread src/components/RightSidebar/RightSidebar.vue
Comment thread src/components/RightSidebar/RightSidebar.spec.js Outdated
@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Jan 9, 2026
@existentialcoder
Copy link
Copy Markdown
Contributor Author

existentialcoder commented Jan 13, 2026

@Antreesy Apologies for the delay.

Addressed review comments on the latest commit and updated the screenshots in the description. Request to re-review

Antreesy
Antreesy reviewed Jan 13, 2026
View reviewed changes
Comment thread src/components/RightSidebar/RightSidebar.vue Outdated
import { showMessage } from '@nextcloud/dialogs'
import { emit, subscribe, unsubscribe } from '@nextcloud/event-bus'
import { t } from '@nextcloud/l10n'
import { getCanonicalLocale, t } from '@nextcloud/l10n'
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all remaining changes from previous commits

Comment thread src/components/RightSidebar/RightSidebar.vue Outdated
background-color: var(--color-primary-element);
pointer-events: none;
}

Copy link
Copy Markdown
Contributor

@Antreesy Antreesy Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And all changes that are not related to the feature

Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
Antreesy
Antreesy reviewed Jan 13, 2026
View reviewed changes
Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
@Antreesy
Copy link
Copy Markdown
Contributor

Antreesy commented Jan 13, 2026

Almost good to go! Please squash your commit into one, and sign it off (see red CI check for DCO for more information)

@existentialcoder existentialcoder force-pushed the iss-16659 branch 2 times, most recently from 152d956 to 915e569 Compare January 13, 2026 18:40
@existentialcoder
Copy link
Copy Markdown
Contributor Author

existentialcoder commented Jan 13, 2026

Almost good to go! Please squash your commit into one, and sign it off (see red CI check for DCO for more information)

Hope its good to go. Let me know

Antreesy
Antreesy approved these changes Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise good!

Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
Comment thread src/components/RightSidebar/RightSidebarContent.vue Outdated
@existentialcoder
feat(message-expiry): Add message expiry msg on the right side bar
a07693d 
Signed-off-by: existentialcoder <shravanayyappa@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 23, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Antreesy
Antreesy approved these changes Jan 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this has tottaly slipped my attention 🙈
Thanks for the contribution!

@Antreesy Antreesy merged commit 289f057 into nextcloud:main Jan 23, 2026
57 checks passed
@Antreesy
Copy link
Copy Markdown
Contributor

Antreesy commented Jan 23, 2026

/backport to stable33

@backportbot backportbot Bot mentioned this pull request Jan 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

enhancement feature: frontend 🖌️ "Web UI" client feedback-requested

Projects

None yet

Milestone

🏖️ Next Major (34)

Development

Successfully merging this pull request may close these issues.

Chat should permanently indicate whether message expiration is set up

3 participants

@existentialcoder @Antreesy @nickvergessen