feat: add replay TTS audio button in WalkieTalkie and Conversation modes#183
Merged
Conversation
Owner
|
Hi @NikolaCavendish, thank you very much for your contribution! |
niedev
approved these changes
May 26, 2026
Owner
niedev
left a comment
There was a problem hiding this comment.
Very good job! The only thing missing is the state management of the TTS inside the Service, but now I will do changes to the TTS logic, so it is better this way. I will directly implement the state management with the new logic, but this is a good base for everything else.
Now I will merge the PR, thank you again for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented manual TTS playback functionality for both WalkieTalkie and Conversation modes, allowing users to conveniently replay translated messages via a speaker icon. Integrated a precise cross-process
onTTSDonecallback mechanism for accurate UI state synchronization.Details
WalkieTalkieandConversationmodes. Tweaked text containers withlayout_weight="1"incomponent_message_send.xmlandcomponent_message_received.xmlto prevent long translated texts from overlapping the icon.VoiceTranslationServiceCommunicatorto attach a uniqueutteranceId(timestamp-based) duringspeakTextcalls. The UI correctly identifies the finished playback and resets the stop icon back to the play icon.onTTSDonein the baseVoiceTranslationServiceCallback, and safely overloaded thespeak()method to prevent breaking existing auto-translation logic inWalkieTalkieServiceandConversationService.Other
None