thinkpad-led

[zeti1223]

Plugin

• Id: <author>/<plugin>
• New plugin
• Update to an existing plugin (version bumped in plugin.toml)

What it does

External dependencies

Testing

• Tested on Niri
• Tested on Hyprland
• Tested on Sway
• Tested on another compositor:
• Noctalia version tested against:
• Plugin API level:

Screenshots / Videos

Checklist

• The directory name matches the part of id after the / in plugin.toml exactly.
• It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
• README.md follows the
  README template, documents
  every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
• I created thumbnail.webp with the thumbnail generator.
• version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
• Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
  understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
• I did not edit catalog.toml; CI generates it.
• This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:

• The code is readable and not obfuscated, minified, or generated.
• It does not download and execute remote code.
• Every network call, filesystem write, and spawned process is something the description above accounts for.
• I have the right to publish this code under the license declared in plugin.toml.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[ItsLemmy]

1. blocking - thinkpad-led/widget.luau:8

The widget never reads the hardware brightness. Each load assumes the LED is off, then onClick
flips that guessed state and renders it immediately without checking the asynchronous command
result. thinkpad-led/widget.luau:39, thinkpad-led/widget.luau:42

If the LED is already on, the first click writes 255 again instead of turning it off. If the
device path is absent or the write fails, the tooltip still claims the state changed. Read the
actual brightness before toggling and update the UI only after a successful write, with an
unavailable or error state when reading or writing fails.

2. blocking - thinkpad-led/plugin.toml:1

The PR description still contains the placeholder ID <author>/<plugin>, leaves What it does and
External dependencies empty, omits the tested Noctalia version and Plugin API level, and provides
no screenshot under the required visual section. This is incomplete capability metadata despite
the plugin spawning sh and writing to sysfs. thinkpad-led/plugin.toml:7,
thinkpad-led/widget.luau:42

Complete the PR form with the actual ID, behavior, dependency, fixed filesystem write, testing
details, and screenshot before acceptance.

3. non-blocking - thinkpad-led/README.md:11

The README reports version 1.1.0, while the authoritative manifest reports 1.0.0 at
thinkpad-led/plugin.toml:3. Keep the published metadata consistent.