Skip to content

add utp-native - #610

Open
mafintosh wants to merge 2 commits into
nodejs:mainfrom
mafintosh:patch-1
Open

mafintosh wants to merge 2 commits into
nodejs:mainfrom
mafintosh:patch-1

Conversation

@mafintosh

@mafintosh mafintosh commented Oct 13, 2018

Copy link
Copy Markdown
Member

As discussed at the collab summit this adds utp-native, which is a precompiled native module that uses n-api and libuv.

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • contribution guidelines followed here

@richardlau

Copy link
Copy Markdown
Member

Please could you specify the hard and soft requirements the module fufills?
https://github.com/nodejs/citgm/blob/master/CONTRIBUTING.md#submitting-a-module-to-citgm

@BridgeAR

Copy link
Copy Markdown
Member

Ping @mafintosh

@BridgeAR BridgeAR added the WIP Work in progress label May 14, 2019
@MylesBorins
MylesBorins changed the base branch from master to main August 14, 2020 21:00
@targos

targos commented Mar 6, 2021

Copy link
Copy Markdown
Member

@targos

targos commented Mar 6, 2021

Copy link
Copy Markdown
Member

Unfortunately, I think there's no way at the moment to make CITGM run something before npm install, and it seems necessary here to pull the git submodule.

@targos

targos commented Mar 6, 2021

Copy link
Copy Markdown
Member

I got an idea. Rebased your branched and added:

    "install": ["install", "--ignore-scripts"],
    "scripts": ["fetch-libutp", "install", "test"]

CI: https://github.com/targos/citgm/actions/runs/627169509

@targos

targos commented Mar 6, 2021

Copy link
Copy Markdown
Member

Of course, now it doesn't work because we don't clone the repository to test. We download the tarball from github.

@codecov-io

This comment has been minimized.

Comment thread lib/lookup.json Outdated
@targos

targos commented Mar 7, 2021

Copy link
Copy Markdown
Member

@MylesBorins

Copy link
Copy Markdown
Contributor

Hey all, I made a boo boo on main and had to force push. I've rebased this branch and force pushed to make sure that you don't have to do extra work because of my mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants