add utp-native - #610
Open
mafintosh wants to merge 2 commits into
Open
add utp-native#610mafintosh wants to merge 2 commits into
mafintosh wants to merge 2 commits into
Conversation
Member
|
Please could you specify the hard and soft requirements the module fufills? |
Member
|
Ping @mafintosh |
Member
|
Let's try it: https://github.com/targos/citgm/actions/runs/627140345 |
Member
|
Unfortunately, I think there's no way at the moment to make CITGM run something before |
Member
|
I got an idea. Rebased your branched and added: |
Member
|
Of course, now it doesn't work because we don't clone the repository to test. We download the tarball from github. |
This comment has been minimized.
This comment has been minimized.
targos
reviewed
Mar 7, 2021
Member
Contributor
|
Hey all, I made a boo boo on main and had to force push. I've rebased this branch and force pushed to make sure that you don't have to do extra work because of my mistake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at the collab summit this adds utp-native, which is a precompiled native module that uses n-api and libuv.
Checklist
npm testpasses