Skip to content

refactor(legacy): extract @nodejs/doc-kit-generator-legacy package - #960

Merged
avivkeller merged 1 commit into
refactor/react-kittenfrom
refactor/legacy-kitten
Aug 4, 2026
Merged

refactor(legacy): extract @nodejs/doc-kit-generator-legacy package#960
avivkeller merged 1 commit into
refactor/react-kittenfrom
refactor/legacy-kitten

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 30, 2026

Copy link
Copy Markdown
Member

The legacy-format generators (legacy-html, legacy-html-all, legacy-json, and legacy-json-all) have moved into the new @nodejs/doc-kit-generator-legacy package (entering npm at 1.0.0), and are loaded via import specifiers such as @nodejs/doc-kit-generator-legacy/legacy-html.

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Aug 4, 2026 3:16pm

Request Review

@avivkeller
avivkeller marked this pull request as ready for review July 30, 2026 21:34
@avivkeller
avivkeller requested a review from a team as a code owner July 30, 2026 21:34
Copilot AI lite review requested due to automatic review settings July 30, 2026 21:34
@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Major semver and removal of @node-core/doc-kit/legacy-* exports break direct importers until they add @nodejs/doc-kit-generator-legacy; runtime behavior should match if the peer package is installed, matching the react generator split pattern.

Overview
Moves the four legacy generators (legacy-html, legacy-html-all, legacy-json, legacy-json-all) from @node-core/doc-kit into a new @nodejs/doc-kit-generator-legacy package (packages/legacy), with exports like @nodejs/doc-kit-generator-legacy/legacy-html.

Core removes the ./legacy-* package exports and adds an optional peer dependency on the legacy package. The generator lookup table in publicGenerators now points legacy shorthand names at the new import specifiers; CLI/config shorthand names are unchanged.

legacyToJSON is removed from core utils and lives under packages/legacy (tests moved accordingly). Legacy generator code now imports shared utilities from @node-core/doc-kit instead of relative paths into core.

Tooling updates coverage/eslint paths from packages/core/src/generators/legacy-html/assets to packages/legacy/src/legacy-html/assets. Changeset marks major bumps for @node-core/doc-kit and @nodejs/doc-kit-generator-legacy.

Reviewed by Cursor Bugbot for commit 7471891. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 1, 2026 10:36
@ovflowd
ovflowd force-pushed the refactor/legacy-kitten branch from 9d9d060 to 0f93e3d Compare August 1, 2026 10:36
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (60d4518) to head (7471891).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           refactor/react-kitten     #960   +/-   ##
======================================================
  Coverage                  89.63%   89.64%           
======================================================
  Files                        198      200    +2     
  Lines                      18482    18495   +13     
  Branches                    1727     1729    +2     
======================================================
+ Hits                       16566    16579   +13     
  Misses                      1909     1909           
  Partials                       7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovflowd

ovflowd commented Aug 1, 2026

Copy link
Copy Markdown
Member

The legacy-format generators (legacy-html, legacy-html-all, legacy-json, and legacy-json-all) have moved into the new @doc-kittens/legacy package, and are loaded via import specifiers such as @doc-kittens/legacy/legacy-html.

nit: can we name it @doc-kittens/legacy-nodejs? (also fine w/ current)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0f93e3d. Configure here.

Comment thread eslint.config.mjs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 45 changed files in this pull request and generated 1 comment.

Comment thread .changeset/legacy-kitten-package.md Outdated
@avivkeller
avivkeller force-pushed the refactor/legacy-kitten branch from 0f93e3d to d75c211 Compare August 1, 2026 15:26
Copilot AI review requested due to automatic review settings August 3, 2026 17:01
@avivkeller
avivkeller force-pushed the refactor/legacy-kitten branch from d75c211 to 2fdc942 Compare August 3, 2026 17:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@avivkeller avivkeller changed the title refactor(legacy): extract @doc-kittens/legacy package refactor(legacy): extract @nodejs/doc-kit-legacy package Aug 3, 2026
Copilot AI review requested due to automatic review settings August 4, 2026 02:43
@avivkeller
avivkeller force-pushed the refactor/legacy-kitten branch from 2fdc942 to e2f3047 Compare August 4, 2026 02:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@avivkeller avivkeller changed the title refactor(legacy): extract @nodejs/doc-kit-legacy package refactor(legacy): extract @nodejs/doc-kit-generator-legacy package Aug 4, 2026

@bmuenzenmeyer bmuenzenmeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the stack so we can test and iterate

Copilot AI review requested due to automatic review settings August 4, 2026 15:15
@avivkeller
avivkeller force-pushed the refactor/legacy-kitten branch from e2f3047 to 7471891 Compare August 4, 2026 15:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@avivkeller
avivkeller merged commit c734403 into main Aug 4, 2026
16 of 18 checks passed
@avivkeller
avivkeller deleted the refactor/legacy-kitten branch August 4, 2026 15:17
@github-actions github-actions Bot mentioned this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants