Skip to content

test: use escapes for non-Latin1 characters - #22

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
mertcanaltin:test-escape-non-latin1
Nov 16, 2026
Merged

aduh95 merged 1 commit into
nodejs:mainfrom
mertcanaltin:test-escape-non-latin1

Conversation

@mertcanaltin

Copy link
Copy Markdown
Member

MSVC reads the source file as Windows-1252 without /utf-8. So 中 and Ľ become more code units, and the tests fail on Windows.
I use \u escapes, so the tests are the same on every compiler.

The Windows CI can build after #21. Then this PR fixes the failing tests.

MSVC reads the source as Windows-1252 without /utf-8, so the
characters become more code units and the tests fail on Windows.

Assisted-by: a coding agent
@aduh95
aduh95 merged commit 7dcaf74 into nodejs:main Nov 16, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants