Skip to content

esm,loader: make evaluation errors catchable #44396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JakobJingleheimer wants to merge 1 commit into from
Closed

esm,loader: make evaluation errors catchable #44396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/internal/modules/esm/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const {
ObjectDefineProperty,
ObjectSetPrototypeOf,
PromiseAll,
PromisePrototypeCatch,
RegExpPrototypeExec,
SafeArrayIterator,
SafeWeakMap,
Expand Down Expand Up @@ -525,9 +526,12 @@ class ESMLoader {
.then(({ module }) => module.getNamespace());
}

const namespaces = await PromiseAll(new SafeArrayIterator(jobs));
const namespaces = await PromisePrototypeCatch(
PromiseAll(new SafeArrayIterator(jobs)),
(err) => { throw err; }, // Make errors catchable in a custom loader.
Copy link
Member

@ljharb ljharb Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default catch handler - I’m not sure why this has any effect?

Copy link
Member Author

@JakobJingleheimer JakobJingleheimer Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm confused: it wasn't working before this, I add it, it's working, I remove it, it's still working.

Copy link
Contributor

@aduh95 aduh95 Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's probably something else that changed on your end, this change should have no effect on the catchability of errors.

Copy link
Member Author

@JakobJingleheimer JakobJingleheimer Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. I can't explain it

);

if (!wasArr) { return namespaces[0]; } // We can skip the pairing below
if (!wasArr) { return namespaces[0]; } // We can skip the pairing below.

for (let i = 0; i < count; i++) {
const namespace = ObjectCreate(null);
Expand Down