module: remove --experimental-transform-types#61803
module: remove --experimental-transform-types#61803nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
|
Review requested:
|
2ea1afe to
c62af40
Compare
I think we should add Then the question becomes what to do with For the purposes of this PR, perhaps the simplest thing to do would be to just keep |
|
User can run |
I wouldn't do that:
Why risk it? |
If we think thats a possibility in the future, then we should keep TLDR - keep this semver-major change as breaking only for those using transform but anyone using strip should not have a breaking change. Does that make sense? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61803 +/- ##
==========================================
+ Coverage 88.84% 89.66% +0.82%
==========================================
Files 674 676 +2
Lines 204957 205951 +994
Branches 39309 39434 +125
==========================================
+ Hits 182087 184670 +2583
+ Misses 15088 13426 -1662
- Partials 7782 7855 +73
🚀 New features to boost your workflow:
|
|
This PR's goal is to remove transform-types. So in this PR, I think just remove the |
c62af40 to
70303e1
Compare
|
Applied suggestions, only remove transform related stuff |
70303e1 to
50a77db
Compare
|
Cna someone help me understand the CI failure? |
The node/test/parallel/test-runner-cli.js Lines 67 to 68 in 50a77db |
That doesn't really make sense, type stripping has been unflagged for a while, that flag is now a no-op. The issue seems to be that the following branch is no longer needed: node/test/parallel/test-runner-cli.js Lines 71 to 74 in 50a77db |
|
The flag still forces an early exit if no amaro, but if it's not provided, then the default-off behaviour can still be tested. assert.strictEqual(child.stderr.toString(), '');
const stdout = child.stdout.toString();
assert.match(stdout, /ok 1 - this should pass/);
assert.match(stdout, /ok 2 - this should pass/);
assert.match(stdout, /ok 3 - this should pass/);
if (!process.config.variables.node_use_amaro) {
// e.g. Compiled with `--without-amaro`.
assert.doesNotMatch(stdout, /ok 4 - this should pass/);
} else {
assert.match(stdout, /ok 4 - this should pass/);
assert.match(stdout, /ok 5 - this should pass/);
assert.match(stdout, /ok 6 - this should pass/);
}
assert.strictEqual(child.status, 0);
assert.strictEqual(child.signal, null); |
50a77db to
1708c57
Compare
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Commit Queue failed- Loading data for nodejs/node/pull/61803 ✔ Done loading data for nodejs/node/pull/61803 ----------------------------------- PR info ------------------------------------ Title module: remove --experimental-transform-types (#61803) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch marco-ippolito:rip-transform-type -> nodejs:main Labels module, semver-major, notable-change, strip-types Commits 1 - module: remove --experimental-transform-types Committers 1 - Marco Ippolito <marcoippolito54@gmail.com> PR-URL: https://github.com/nodejs/node/pull/61803 Refs: https://github.com/nodejs/typescript/issues/51 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61803 Refs: https://github.com/nodejs/typescript/issues/51 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - module: remove --experimental-transform-types ℹ This PR was created on Fri, 13 Feb 2026 16:37:18 GMT ✔ Approvals: 5 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/61803#pullrequestreview-3812003275 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/61803#pullrequestreview-3842407971 ✔ - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/61803#pullrequestreview-3842748844 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/61803#pullrequestreview-3842760049 ✔ - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/61803#pullrequestreview-3843627386 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-02-27T14:44:13Z: https://ci.nodejs.org/job/node-test-pull-request/71481/ - Querying data for job/node-test-pull-request/71481/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/22494002497 |
|
Landed in 89f4b6c |
This PR removes the
--experimental-transform-typesflag and all related code, tests, and documentation.Refs: nodejs/typescript#51