Skip to content

test_runner: preserve signal-based interruption exit codes#62359

Open
ace-tk wants to merge 1 commit intonodejs:mainfrom
ace-tk:fix/test-runner-signal-exit-codes
Open

test_runner: preserve signal-based interruption exit codes#62359
ace-tk wants to merge 1 commit intonodejs:mainfrom
ace-tk:fix/test-runner-signal-exit-codes

Conversation

@ace-tk
Copy link
Copy Markdown

@ace-tk ace-tk commented Mar 21, 2026

Summary

  • preserve signal-based exit semantics when test runner is interrupted
  • set SIGINT/SIGTERM derived exit codes (130/143)
  • update test-runner-exit-code coverage for both signals

Test plan

  • python3 tools/test.py test/parallel/test-runner-exit-code.js

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 21, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.68%. Comparing base (69fdff9) to head (83c163f).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/harness.js 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62359      +/-   ##
==========================================
+ Coverage   89.67%   89.68%   +0.01%     
==========================================
  Files         676      676              
  Lines      206693   206697       +4     
  Branches    39576    39582       +6     
==========================================
+ Hits       185346   185376      +30     
+ Misses      13482    13460      -22     
+ Partials     7865     7861       -4     
Files with missing lines Coverage Δ
lib/internal/test_runner/harness.js 87.02% <88.88%> (-0.11%) ⬇️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atlowChemi
Copy link
Copy Markdown
Member

@ace-tk could you take a look? the tests failing are related to the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants