stream: fix Utf8Stream stall after full write of multi-byte data#63964
Open
watilde wants to merge 1 commit into
Open
stream: fix Utf8Stream stall after full write of multi-byte data#63964watilde wants to merge 1 commit into
watilde wants to merge 1 commit into
Conversation
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
releaseWritingBuf() tracks the buffered length in characters but, on a full write, decremented it by the number of bytes reported by fs.write instead of the number of characters. For multi-byte UTF-8 data this drove the internal length to zero, so the stream emitted 'drain' and went idle while queued chunks were left unwritten. Convert the byte count to a character count in the full-write case as well.