src: export manually declared postmortem metadata - #64983
Open
Archkon wants to merge 1 commit into
Open
Conversation
Apply NODE_EXTERN to the manually declared nodedbg_* symbols, matching the macro-generated metadata. This prevents Windows LTCG from discarding symbols required by postmortem debugging tools. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
nodejs-github-bot
added
c++
Contributor
Author
|
ping @StefanStojanovic |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64983 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 762 762
Lines 247524 247524
Branches 46693 46684 -9
=======================================
+ Hits 223451 223458 +7
Misses 15494 15494
+ Partials 8579 8572 -7
🚀 New features to boost your workflow:
|
StefanStojanovic
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Contributor
Author
|
@StefanStojanovic Could you take a look at these failed tests ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply NODE_EXTERN to the manually declared nodedbg_* symbols, matching the macro-generated metadata. This prevents Windows LTCG from discarding symbols required by postmortem debugging tools.