doc: narrow ReadableStreamBYOBRequest.view type to Uint8Array - #64997
Open
aalhadxx wants to merge 1 commit into
Open
doc: narrow ReadableStreamBYOBRequest.view type to Uint8Array#64997aalhadxx wants to merge 1 commit into
aalhadxx wants to merge 1 commit into
Conversation
Fixes: nodejs#62952 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aalhad <aalhadxx@users.noreply.github.com>
aalhadxx
force-pushed
the
fix/issue-62952
branch
2 times, most recently
from
August 4, 2026 15:07
bc8bbd8 to
4d70d0a
Compare
Author
|
Hi team, this is a small doc fix for the ReadableStreamBYOBRequest.view type. The commit is signed. Could a maintainer review it? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62952
What does this PR do?
Narrows the documented type of
ReadableStreamBYOBRequest.viewfromArrayBufferViewtoUint8Arrayin the Node.js Web Streams API documentation. This matches the actual WebIDL and Chromium/Node implementation, where a BYOB request always provides aUint8Arrayview.Changes
doc/api/webstreams.md: one-line type change in theReadableStreamBYOBRequestsection.How did you verify your code works?
ReadableStreamBYOBRequest.viewis created from aUint8Arrayin the implementation.make docand confirmed the generated HTML reflects the narrowed type without breaking surrounding anchors.