Skip to content

dns: fix crash on setServers with port 0 #65009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −4
Open

dns: fix crash on setServers with port 0 #65009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
948d758
dns: fix crash on setServers with port 0
lazerg Aug 4, 2026
42c89ee
dns: keep type assertions in SetServers
lazerg Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/cares_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2251,13 +2251,13 @@ void SetServers(const FunctionCallbackInfo<Value>& args) {
if (!elm->Get(env->context(), 1).ToLocal(&ipValue)) return;
if (!elm->Get(env->context(), 2).ToLocal(&portValue)) return;

CHECK(familyValue->Int32Value(env->context()).FromJust());
CHECK(familyValue->IsInt32());
CHECK(ipValue->IsString());
Comment thread
Renegade334 marked this conversation as resolved.
CHECK(portValue->Int32Value(env->context()).FromJust());
CHECK(portValue->IsInt32());

int fam = familyValue->Int32Value(env->context()).FromJust();
int32_t fam = familyValue.As<Int32>()->Value();
node::Utf8Value ip(env->isolate(), ipValue);
int port = portValue->Int32Value(env->context()).FromJust();
int32_t port = portValue.As<Int32>()->Value();

if (!csv.empty()) csv += ',';

Expand Down
4 changes: 4 additions & 0 deletions test/parallel/test-dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ const portsExpected = [
dns.setServers(ports);
assert.deepStrictEqual(dns.getServers(), portsExpected);

// Port 0 means "use the default port" for c-ares.
dns.setServers(['4.4.4.4:0', '[2001:4860:4860::8888]:0']);
assert.deepStrictEqual(dns.getServers(), ['4.4.4.4', '2001:4860:4860::8888']);

// Link-local IPv6 addresses require a zone index (scope id) to be usable;
// c-ares drops link-local servers configured without one.
dns.setServers(['[fe80::483a:5aff:fee6:1f04]%eth0']);
Expand Down
Loading