feat(dispatcher/env-http-proxy-agent): strip leading dot and asterisk#4676
Merged
mcollina merged 1 commit intonodejs:mainfrom Feb 7, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4676 +/- ##
=========================================
+ Coverage 0 92.85% +92.85%
=========================================
Files 0 107 +107
Lines 0 33498 +33498
=========================================
+ Hits 0 31103 +31103
- Misses 0 2395 +2395 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Nov 26, 2025
Member
|
@joyeecheung can you review? |
Contributor
Author
Just reminder 🙏 |
Member
|
LGTM as far as I can tell from the blog post. Not sure if I should really use the approve button as I am not a undici collaborator but have write permission by chance here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
#4618
Rationale
no_proxymatching logic changes related to current behaviour incurl,denoand this specification - https://about.gitlab.com/blog/we-need-to-talk-no-proxy/Changes
no_proxy=.example.comis equivalent tono_proxy=example.comno_proxy=*.example.comis equivalent tono_proxy=example.comno_proxy=*exampleis equivalent tono_proxy=""or the absence of ano_proxyvariableBreaking Changes and Deprecations
Сhanges in the current Merge Request can be considered as breaking.
Status