fix: handle undefined __filename in bundled environments #4812
+18
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When undici is bundled inside Node.js as an internal module,
__filenameis not defined. This causes aReferenceErrorwhenfetch()fails, which swallows the original error and replaces it with the ReferenceError, makingerr.causeundefined.This was introduced in #4778.
The Problem
The code added in #4778:
When bundled in Node.js internals,
__filenameis not available, causing:This error is thrown inside the
.catch()handler, replacing the original fetch error. As a result,err.causebecomesundefinedinstead of containing the actual error.The Fix
__filenameat module load time, defaulting toundefinedif not available__filenameis availableError.captureStackTrace(err)behavior when__filenameis not availableTesting
npx borp -p "test/fetch/client-error-stack-trace.js"test-permission-net-fetch.jstest-tls-set-default-ca-certificates-append-fetch.mjstest-tls-set-default-ca-certificates-reset-fetch.mjsRefs: nodejs/node#61683, nodejs/node#61679