feat(DEP0066): `OutgoingMessage` headers by elvessilvavieira · Pull Request #281 · nodejs/userland-migrations

elvessilvavieira · 2025-11-23T22:21:30Z

Here's a draft. I'd like to know if I'm on the right track. There are some things missing, like the README, but I'll add them. Thx

Resolves #128

AugustinMauroy · 2025-11-24T07:47:39Z

No need to ping me, I receive notification for all thing on the repo

AugustinMauroy

Not too bad there are some pont that you can improve 👍

AugustinMauroy · 2025-11-24T07:59:30Z

+    const matches = rootNode.findAll({
+      rule: { pattern: "$OBJ._headers[$KEY]" },
+    });
+    for (const m of matches) {


Suggested change

for (const m of matches) {

for (const m of matches) {

AugustinMauroy · 2025-11-24T08:07:37Z

+
+  {
+    const matches = rootNode.findAll({
+      rule: { pattern: "$OBJ._headers[$KEY]" },


main part here...

Here if the user code have ah propriety expression _headers it's will be catch. We need a more complex logic to catch http usage and -> catch response objects -> catch _headers

I have to admit that the orignal issue examples wasn't 100% complete

AugustinMauroy · 2025-12-13T09:48:25Z

bump @elvessilvavieira 👋

elvessilvavieira · 2025-12-13T23:13:07Z

Hi, Augustin

I renamed the folder to http-outgoing message-headers then created a function looksLikeOutgoingMessage. pls tell me if it's weak in preventing false positives, or if there are any utilities that could help me. I even considered using resolveBindingPath for when they explicitly use http.createServer, but it has some drawbacks

AugustinMauroy · 2025-12-15T19:37:46Z

Hi, Augustin

I renamed the folder to http-outgoing message-headers then created a function looksLikeOutgoingMessage. pls tell me if it's weak in preventing false positives, or if there are any utilities that could help me. I even considered using resolveBindingPath for when they explicitly use http.createServer, but it has some drawbacks

Yeah to have better handling of the detection/node catch workflow we can use https://docs.codemod.com/jssg/semantic-analysis which is a brand new feature of codemod

BTW codemod have a mcp that can help you it's aware of this new feature

…e-headers)

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

JakobJingleheimer

W00t! 🚀

JakobJingleheimer · 2026-01-25T16:47:43Z

+schema_version: "1.0"
+name: "@nodejs/http-outgoingmessage-headers"
+version: 1.0.0
+description: Handle DEP0066: migrate deprecated use of `OutgoingMessage.prototype` `_headers` & `_headerNames` to public HTTP header APIs


Oh, whoops. My bad:

Error: 4:28 syntax error: mapping values are not allowed here (syntax)

https://github.com/nodejs/userland-migrations/actions/runs/21335657538/job/61408018425?pr=281#step:5:66

I think it doesn't like the :

Suggested change

description: Handle DEP0066: migrate deprecated use of `OutgoingMessage.prototype` `_headers` & `_headerNames` to public HTTP header APIs

description: Handle DEP0066 - migrate deprecated use of `OutgoingMessage.prototype` `_headers` & `_headerNames` to public HTTP header APIs

JakobJingleheimer · 2026-01-25T16:50:14Z

The lint is failing on test files. I think we should perhaps ignore test files for linting since we may need to explicitly handle syntax the linter disallows; if so, let's do that in a separate PR and merge it (via main) into this one to resolve those lint issues.

https://github.com/nodejs/userland-migrations/actions/runs/21335657538/job/61408018422?pr=281

brunocroh · 2026-01-25T18:05:08Z

The lint is failing on test files. I think we should perhaps ignore test files for linting since we may need to explicitly handle syntax the linter disallows; if so, let's do that in a separate PR and merge it (via main) into this one to resolve those lint issues.

https://github.com/nodejs/userland-migrations/actions/runs/21335657538/job/61408018422?pr=281

Done here #355

JakobJingleheimer

🙌

AugustinMauroy reviewed Nov 24, 2025

View reviewed changes

AugustinMauroy added the awaiting author Reviewer has requested something from the author label Dec 13, 2025

feat(outgoingmessage-headers)

06a18ea

elvessilvavieira force-pushed the feat(outgoingmessage-headers) branch from 259f795 to 06a18ea Compare December 13, 2025 23:08

brunocroh added 7 commits January 23, 2026 20:21

Merge remote-tracking branch 'upstream/main' into feat(outgoingmessag…

726fd2b

…e-headers)

feat: add needed testcases

ebf896f

add base implementation

32fe509

add support to server.on

ce6344a

add support to look for variable declarations

256eabc

add supports to events checkContinue and checkExpectation

57bb13a

add support to function_declaration

e2d2aea

brunocroh requested a review from AugustinMauroy January 24, 2026 22:40

brunocroh added 2 commits January 24, 2026 22:44

update readme.md

0620626

update readme.md

a533fb8

brunocroh marked this pull request as ready for review January 24, 2026 22:50

chore code style

f7930bc

brunocroh added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Jan 24, 2026

JakobJingleheimer changed the title ~~feat(outgoingmessage-headers)~~ feat(DEP0066): OutgoingMessage headers Jan 25, 2026

JakobJingleheimer added this to Userland Migrations Board Jan 25, 2026

JakobJingleheimer moved this to 🏗 In progress in Userland Migrations Board Jan 25, 2026

JakobJingleheimer added this to the 22.x → 24.x milestone Jan 25, 2026

JakobJingleheimer approved these changes Jan 25, 2026

View reviewed changes

JakobJingleheimer added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Jan 25, 2026

Update recipes/http-outgoingmessage-headers/codemod.yaml

44affcc

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

brunocroh and others added 5 commits January 25, 2026 13:14

Update recipes/http-outgoingmessage-headers/package.json

2a7b0b7

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

Update recipes/http-outgoingmessage-headers/readme.md

f905f17

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

Update recipes/http-outgoingmessage-headers/codemod.yaml

e2129f1

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

Update recipes/http-outgoingmessage-headers/package.json

a603f86

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

fix: improve logic with early returns and prevent array reconstruction

b373999

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

brunocroh added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Jan 25, 2026

JakobJingleheimer approved these changes Jan 25, 2026

View reviewed changes

JakobJingleheimer removed the awaiting reviewer Author has responded and needs action from the reviewer label Jan 25, 2026

JakobJingleheimer reviewed Jan 25, 2026

View reviewed changes

fix: yml lint

8c32a71

brunocroh added 2 commits January 25, 2026 18:09

chore: lint on recipe workflow file

3fa1e26

fix: early return

c6a1779

JakobJingleheimer approved these changes Jan 25, 2026

View reviewed changes

Merge branch 'main' into feat(outgoingmessage-headers)

2225f92

JakobJingleheimer approved these changes Jan 25, 2026

View reviewed changes

JakobJingleheimer requested review from avivkeller and brunocroh January 25, 2026 19:59

JakobJingleheimer added the g2g No outstanding concerns, discussions, or issues. label Jan 25, 2026

brunocroh approved these changes Jan 25, 2026

View reviewed changes

JakobJingleheimer merged commit 1fdb966 into nodejs:main Jan 25, 2026
18 checks passed

brunocroh mentioned this pull request Jan 26, 2026

spec(v22-to-v24): what we have to do #239

Open

18 tasks

JakobJingleheimer removed the g2g No outstanding concerns, discussions, or issues. label Mar 21, 2026

	description: Handle DEP0066: migrate deprecated use of `OutgoingMessage.prototype` `_headers` & `_headerNames` to public HTTP header APIs
	description: Handle DEP0066 - migrate deprecated use of `OutgoingMessage.prototype` `_headers` & `_headerNames` to public HTTP header APIs

Uh oh!

Conversation

elvessilvavieira commented Nov 23, 2025 • edited by JakobJingleheimer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AugustinMauroy commented Nov 24, 2025

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AugustinMauroy Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy commented Dec 13, 2025

Uh oh!

elvessilvavieira commented Dec 13, 2025

Uh oh!

AugustinMauroy commented Dec 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunocroh commented Jan 25, 2026

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elvessilvavieira commented Nov 23, 2025 •

edited by JakobJingleheimer

Loading

JakobJingleheimer commented Jan 25, 2026 •

edited

Loading