Skip to content

fix: correct code colors#2362

Open
alexdln wants to merge 1 commit intonpmx-dev:mainfrom
alexdln:fix/correct-code-colors
Open

fix: correct code colors#2362
alexdln wants to merge 1 commit intonpmx-dev:mainfrom
alexdln:fix/correct-code-colors

Conversation

@alexdln
Copy link
Copy Markdown
Member

@alexdln alexdln commented Apr 2, 2026

🧭 Context

Missed one rule on revert :(

So final touch, checked everything else and now that's all

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 2, 2026 11:23am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 2, 2026 11:23am
npmx-lunaria Ignored Ignored Apr 2, 2026 11:23am

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7166a654-4d9c-4e2c-9f75-c1084b1bf3d1

📥 Commits

Reviewing files that changed from the base of the PR and between d3f60cb and 1864b2b.

📒 Files selected for processing (1)
  • app/assets/main.css

📝 Walkthrough

Walkthrough

The pull request modifies CSS selectors in the main stylesheet to refine the Shiki syntax-highlighting theme application. The selector scope for light theme styling was narrowed from a global rule to a light-specific rule, restricting when foreground and background colour properties apply. A blank line was also added to a media-contrast block. The changes affect only CSS selector specificity and formatting, with no alterations to exported declarations.

Possibly related PRs

Suggested labels

front

Suggested reviewers

  • RamaHerbin
  • danielroe
  • graphieros
🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is vague and non-descriptive, using informal language like 'Missed one rule on revert' and 'final touch' without clearly conveying what changes were made. Provide a more detailed description explaining what CSS rule was missed, why it needed correction, and how the light/dark theme selector change improves code colour handling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should've seen it too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants