Skip to content

fix(git): git worktree add - branch is optional #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fdncred merged 1 commit into from
Oct 15, 2025
Merged

fix(git): git worktree add - branch is optional #1181

fdncred merged 1 commit into from
Oct 15, 2025
+1 −1

Conversation

@ryan4yin
Copy link
Contributor

@ryan4yin ryan4yin commented Oct 15, 2025 •
edited
Loading

Fix #1153

The completion script wrongly made the branch argument required, blocking Nushell from loading when both git-completions.nu and git-aliases.nu are used.

@fdncred fdncred merged commit 9ce0d5d into nushell:main Oct 15, 2025
1 check passed
@fdncred
Copy link
Contributor

fdncred commented Oct 15, 2025

Thanks

@ryan4yin ryan4yin deleted the fix-git-alias-and-completion branch October 15, 2025 11:44
marwajameel

This comment was marked as off-topic.

Sign in to view

@nushell nushell deleted a comment from marwajameel Jan 11, 2026
@nushell nushell deleted a comment from marwajameel Jan 11, 2026
@nushell nushell locked as off-topic and limited conversation to collaborators Jan 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@marwajameel marwajameel marwajameel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

git completion missing positional error

3 participants

@ryan4yin @fdncred @marwajameel