Strictly typed searching and sorting (docs).#2740
Closed
LastDragon-ru wants to merge 1 commit intonuwave:masterfrom
Closed
Strictly typed searching and sorting (docs).#2740LastDragon-ru wants to merge 1 commit intonuwave:masterfrom
LastDragon-ru wants to merge 1 commit intonuwave:masterfrom
Conversation
spawnia
reviewed
Jan 25, 2026
Collaborator
spawnia
left a comment
spawnia
left a comment
There was a problem hiding this comment.
The functionality looks great and the critique of the Lighthouse implementation is valid. However, I would like to keep our docs more targeted towards how things are done in Lighthouse - without the need to get into nuanced discussions about directive designs, dependencies and more. I left a suggestion at #1782 (comment) for a lightweight reference to your package.
LastDragon-ru
force-pushed
the
strictly-typed-searching-and-sorting
branch
from
fbbe840 to
1f02a2a
Compare
3 tasks
Collaborator
|
Closing this as #2741 is sufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Docs about
@searchByand@sortBydirectives 😀 (#1782)Breaking changes
Nope.