Skip to content

Conversation

@larbish
Copy link
Collaborator

@larbish larbish commented Dec 24, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@larbish larbish requested review from atinux and farnabaz December 24, 2025 14:56
@vercel
Copy link

vercel bot commented Dec 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
content Ready Ready Preview, Comment Dec 24, 2025 3:34pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 24, 2025

npm i https://pkg.pr.new/@nuxt/content@3659

commit: 1b67a9a

:::u-button
---
color: primary
label: Currently in beta
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button component is missing its label text. The original label: Currently in beta attribute was removed without adding replacement text, resulting in a button with no visible content.

View Details
πŸ“ Patch Details
diff --git a/docs/content/index.md b/docs/content/index.md
index 7c72380b..af173a83 100644
--- a/docs/content/index.md
+++ b/docs/content/index.md
@@ -444,6 +444,7 @@ Let [anyone edit]{.text-(--ui-primary)} your website
 :::u-button
 ---
 color: primary
+label: Learn about Studio
 target: _blank
 to: https://github.com/nuxt-content/studio
 variant: outline

Analysis

Missing label text on u-button component in Studio section

What fails: The u-button component at line 444-451 in docs/content/index.md lacks both a label: attribute and text content, rendering as a button with no visible text to the user.

How to reproduce:

  1. Open docs/content/index.md
  2. Navigate to lines 444-451
  3. Observe the button component with color: primary, target: _blank, to: https://github.com/nuxt-content/studio, and variant: outline
  4. Note the absence of label: attribute and empty content between the closing --- and ::: markers

Result: Button renders with no visible text, creating broken UI in the "Let anyone edit your website" section.

Expected behavior: Button should display text matching the pattern used by other button components in the file (e.g., lines 34, 318, 422, 496 which all include label: attributes). The button should show "Learn about Studio" to indicate it links to the Studio GitHub repository.

Context: The button appears in a section announcing the Studio module, linking to https://github.com/nuxt-content/studio. The description text states "Edit your Nuxt Content website with the Studio module", and other similar buttons in the file use descriptive labels like "Learn more about MDC" and "Learn more about content collections".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larbish Sounds valid comment

class: mb-3 rounded-full
---
Nuxt Studio beta is out
Nuxt Studio is out
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Nuxt Studio is out

The headline button has both a label attribute and slot content with identical text, which will likely render the text twice on the page.

View Details

Analysis

Duplicate text in headline button due to both label attribute and slot content

What fails: The headline u-button component (lines 17-27 in docs/content/index.md) has both a label attribute and default slot content with identical text "Nuxt Studio is out", causing potential duplicate rendering or inconsistency with other buttons in the file.

How to reproduce:

docs/content/index.md lines 17-27:
:::u-button
---
size: sm
label: Nuxt Studio is out
to: https://github.com/nuxt-content/studio
variant: outline
trailing-icon: i-lucide-arrow-right
class: mb-3 rounded-full
---
Nuxt Studio is out
:::

Expected vs Actual: According to Nuxt UI Button documentation, the button label can be set using either the label prop OR the default slot, not both. All other buttons in the file follow this pattern - they use ONLY the label attribute (e.g., lines 35-42, 319-327, 423-431, 497-503) with no slot content. Using both simultaneously is inconsistent and could cause the text to render twice depending on component implementation.

Fix applied: Removed the duplicate slot content, keeping only the label attribute to match the established pattern used by all other buttons in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants