Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes Docker an explicit required prerequisite for every managed remote deployment server, including when the OpenShip control plane itself runs in bare mode.
Motivation
The server health-check endpoint derived remote requirements from the control plane's
DEPLOY_MODE. A bare control plane therefore required only Git and omitted Docker from the new-server setup results, even though remote application deployments and the managed Edge container depend on Docker. This allowed setup to appear ready and Edge installation to fail later.Related issue
Closes #767
Changes
Verification
The existing controller file does not pass a whole-file Prettier check on upstream. It was not reformatted to avoid unrelated formatting changes.
Screenshots
Not included. The existing Docker component row is now returned by the backend when missing; this change does not introduce a new UI component.
Checklist