test(spawn): reproduce lost exec errors with closed standard fds#15548
Open
rgrinberg wants to merge 1 commit into
Open
test(spawn): reproduce lost exec errors with closed standard fds#15548rgrinberg wants to merge 1 commit into
rgrinberg wants to merge 1 commit into
Conversation
The spawn error pipe can occupy file descriptors 0 or 1 when standard descriptors are closed. Child redirection then overwrites the pipe write end, so an exec failure looks like a clean close and the parent returns a pid. Fork a helper with stdin and stdout closed, redirect the spawned process to /dev/null, and show that spawning a nonexistent executable currently returns instead of raising. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spawn error pipe can occupy file descriptors 0 or 1 when standard
descriptors are closed. Child redirection then overwrites the pipe write
end, so an exec failure looks like a clean close and the parent returns
a pid.
Fork a helper with stdin and stdout closed, redirect the spawned process
to /dev/null, and show that spawning a nonexistent executable currently
returns instead of raising.