fix(report-specs): isolate CONFIG-tier entries and wire user specs di… - #390
Merged
dwolfson merged 1 commit intoSep 26, 2026
Merged
Conversation
…r into registry A single bad report-spec source (missing file, bad JSON, failed import) silently dropped every configured source after it, and a label that duplicated a built-in made get_report_registry() itself raise. Each entry now loads independently; failures and collisions are skipped with a warning and returned from refresh_report_specs(). The user report specs directory only ever reached the legacy report_specs dict, so registry lookups (select_report_spec etc.) never saw it, and it defaulted to "../" instead of the configured "Pyegeria User Report Specs Dir". Its *.json files are now CONFIG-tier entries, resolved from env var > config.json > ~/.pyegeria/report_specs. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r into registry
A single bad report-spec source (missing file, bad JSON, failed import) silently dropped every configured source after it, and a label that duplicated a built-in made get_report_registry() itself raise. Each entry now loads independently; failures and collisions are skipped with a warning and returned from refresh_report_specs().
The user report specs directory only ever reached the legacy report_specs dict, so registry lookups (select_report_spec etc.) never saw it, and it defaulted to "../" instead of the configured "Pyegeria User Report Specs Dir". Its *.json files are now CONFIG-tier entries, resolved from env var > config.json > ~/.pyegeria/report_specs.