Skip to content

Conversation

@le-lenn
Copy link
Contributor

@le-lenn le-lenn commented Dec 21, 2025

The test sandbox was mounting ${HOME}/.docker/config.json into the manager/worker containers. That made the tests depend on my local Docker config, which was not compatible with the test suite.

This change sets DOCKER_CONFIG=/tmp/docker-config and mounts an empty named volume, keeping the test environment hermetic and consistent across machines.

@m90
Copy link
Member

m90 commented Dec 22, 2025

The idea behind the mount is to achieve the opposite of an isolated config: in CI the host's credentials need to propagate into the container (which is running Docker in Docker) so that pulls are authenticated and builds don't get rate limited (which happens when Dependabot opens multiple PRs at once). Merging this PR would break that behavior.

If you wanted to make this more versatile, it would still need to support the option of mounting the config file as it's done right now.

@le-lenn le-lenn marked this pull request as draft December 23, 2025 13:25
@le-lenn
Copy link
Contributor Author

le-lenn commented Dec 23, 2025

This PR now adds the option to overwrite the docker config. I am not 100% happy with the approach, but I think its a good start for a discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants