Skip to content

Allocate explicit controlled-session subnets - #59

Merged
omry merged 1 commit into
pr58from
pr59
Aug 14, 2026
Merged

Allocate explicit controlled-session subnets#59
omry merged 1 commit into
pr58from
pr59

Conversation

@omry

@omry omry commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Create each controlled-session bridge with a deterministic /29 drawn from the pinned Docker daemon's configured default address pools, falling back to Docker's built-in pools when none are configured. Retry only definitive Docker overlap failures across a bounded candidate set.

Verify the selected subnet and gateway before freezing controller and workload peer addresses, and document the explicit IPAM requirement.

@omry
omry changed the base branch from main to pr58 August 13, 2026 15:08
@omry
omry marked this pull request as ready for review August 13, 2026 15:12
Copilot AI lite review requested due to automatic review settings August 13, 2026 15:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68778d1fc4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/dockerdeploy/controlled_session_network.go Outdated
Create each controlled-session bridge with a deterministic /29 drawn from the pinned Docker daemon's configured default address pools, falling back to Docker's built-in pools when none are configured. Retry only definitive Docker overlap failures across a bounded candidate set.

Verify the selected subnet and gateway before freezing controller and workload peer addresses, and document the explicit IPAM requirement.
@omry

omry commented Aug 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review 20bb82c

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 20bb82c7f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved PR reviewed and approved label Aug 13, 2026
@omry
omry merged commit 84c1dc7 into main Aug 14, 2026
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants