fix: logout issue when key is available but no profile#2214
Conversation
PR SummaryFixed a logout issue that occurred when a key was available but no user profile existed. The changes refactored Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 51fad35: fix: logout issue when key is available but no profile
Files Processed (4)
- FRW.xcodeproj/project.pbxproj (6 hunks)
- FRW/Services/Manager/UserManager.swift (6 hunks)
- FRW/Services/Manager/Wallet/WalletManager.swift (3 hunks)
- Podfile.lock (7 hunks)
Actionable Comments (0)
Skipped Comments (3)
-
FRW/Services/Manager/Wallet/WalletManager.swift [269-273]
possible issue: "Early return may skip key provider update when user exists."
-
FRW/Services/Manager/UserManager.swift [519-520]
maintainability: "Inconsistent ordering of operations compared to other code paths."
-
FRW/Services/Manager/Wallet/WalletManager.swift [279-287]
possible issue: "New user may be created with nil account key."
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 953d4ec: Bump version 3.0.11
Files Processed (1)
- FRW.xcodeproj/project.pbxproj (14 hunks)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- eb05d19: feat: revert podfile.lock
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Files Processed (4)
- FRW.xcodeproj/project.pbxproj (18 hunks)
- FRW/Modules/Buy/BuyProvderView.swift (2 hunks)
- FRW/Modules/Profile/DeveloperMode/DeveloperModeView.swift (1 hunk)
- FRW/Services/Network/FRW/FRWAPI+Utils.swift (4 hunks)
Actionable Comments (1)
-
FRW/Modules/Buy/BuyProvderView.swift [91-91]
typo: "Fix typo in error message."
Skipped Comments (2)
-
FRW/Modules/Buy/BuyProvderView.swift [102-104]
possible issue: "Missing error handling for invalid URL."
-
FRW/Modules/Profile/DeveloperMode/DeveloperModeView.swift [294-294]
possible issue: "Destructive action lacks confirmation dialog."
|
|
||
| private func launchCoinbase() async { | ||
| guard let address = WalletManager.shared.getPrimaryWalletAddress() else { | ||
| HUD.error(title: "Invaild Address") |
There was a problem hiding this comment.
There's a typo in the error message: "Invaild" should be "Invalid".
Related Issue
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)