-
Notifications
You must be signed in to change notification settings - Fork 6
Hotfix/1064 ios integration implement key rotation workflow integration #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/1064 ios integration implement key rotation workflow integration #2265
Conversation
PR SummaryImplemented a key rotation workflow for Blocto accounts on iOS. Added a new Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Pull request needs attention.
Review Summary
Commits Considered (12)
- 6869aed: feat: first filter valid key
- 8635905: feat: empty setScreenSecurityLevel
- 6a8c657: feat: dump version 3.0.12
- 31fde79: fix: UI error on iOS 26
- b89f9d7: feat: update sign param
- fdc4c5a: feat: update route name
- 182f80e: feat: check blocto each time when switch profile
- c77db01: feat: update Model from RN
- 43bbd60: feat: blocto rotation logic
- 9cc225f: feat: check blocto keys
- 277a035: feat: remove event bus pattern
- 83d68fc: feat: add headless rn on app launch
Files Processed (20)
- .gitignore (1 hunk)
- FRW.xcodeproj/project.pbxproj (23 hunks)
- FRW/App/AppDelegate.swift (2 hunks)
- FRW/Foundation/Bridge/BridgeModels.swift (2 hunks)
- FRW/Foundation/Bridge/RCTNativeFRWBridge.mm (2 hunks)
- FRW/Foundation/Bridge/TurboModuleSwift.swift (4 hunks)
- FRW/Foundation/Model/Error.swift (1 hunk)
- FRW/Modules/Login/ViewModel/KeyStoreLoginViewModel.swift (1 hunk)
- FRW/Modules/Login/ViewModel/PrivateKeyLoginViewModel.swift (1 hunk)
- FRW/Modules/Login/ViewModel/SeedPhraseLoginViewModel.swift (1 hunk)
- FRW/Modules/MultiRestore/ViewModel/RestoreMultiConnectViewModel.swift (1 hunk)
- FRW/Modules/PushAlert/PushAlertView.swift (1 hunk)
- FRW/Modules/ReactNative/ReactNativeViewController.swift (7 hunks)
- FRW/Modules/Wallet/FlowWalletKit/KeyChainAccessibilityUpdate.swift (1 hunk)
- FRW/Services/Manager/Wallet/BloctoDetectorService.swift (1 hunk)
- FRW/Services/Manager/Wallet/WalletManager.swift (3 hunks)
- FRW/Services/Router/RouteMap+React.swift (2 hunks)
- FRW/Services/Router/RouteableUIHostingController.swift (4 hunks)
- Podfile.lock (2 hunks)
- main.jsbundle (0 hunks)
Actionable Comments (1)
-
FRW/Foundation/Bridge/TurboModuleSwift.swift [205-207]
possible bug: "Method implementation is incomplete and has no effect."
Skipped Comments (4)
-
FRW/Foundation/Bridge/TurboModuleSwift.swift [143-145]
maintainability: "Incomplete error handling with TODO comment."
-
FRW/Services/Manager/Wallet/BloctoDetectorService.swift [22-51]
performance: "Asymmetric caching may cause unnecessary network requests."
-
FRW/Services/Manager/Wallet/WalletManager.swift [440-452]
possible issue: "Fire-and-forget task may present UI for stale account."
-
FRW/Foundation/Bridge/TurboModuleSwift.swift [479-489]
maintainability: "Unused private extension method."
| static func setScreenSecurityLevel(level: String) { | ||
| let secure = level.lowercased() == "secure" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setScreenSecurityLevel method is implemented but the body does nothing with the secure variable. The computed value is assigned but never used, making this a no-op function.
* fix: logout issue when key is available but no profile * Bump version 3.0.11 * feat: revert podfile.lock * feat: replace coinbase url (#1989) * Hotfix/1064 ios integration implement key rotation workflow integration (#2265) * feat: add headless rn on app launch * feat: remove event bus pattern * feat: check blocto keys * feat: blocto rotation logic * feat: update Model from RN * feat: check blocto each time when switch profile * feat: update route name * feat: update sign param * fix: UI error on iOS 26 * feat: dump version 3.0.12 * feat: empty setScreenSecurityLevel * feat: first filter valid key --------- Co-authored-by: lmcmz <[email protected]> * feat: update RN * feat: filter valid key * feat: format --------- Co-authored-by: lmcmz <[email protected]>
Related Issue
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)