FLOW-5 - Clean up existing capability before granting new beta access #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add _cleanupExistingGrant function that deletes the old capability controller before issuing a new one. This prevents storage bloat and maintains an accurate audit trail when grantBeta() is called for an address that already has beta access. Addresses Quantstamp audit finding FLOW-5. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This was referenced Jan 13, 2026
holyfuchs
reviewed
Jan 15, 2026
holyfuchs
left a comment
holyfuchs
left a comment
There was a problem hiding this comment.
There is a logic inconsistency between the grant and revoke functions in the contract:
revokeByAddress(): Panics if called on an address that is already revoked.grantBeta(): Succeeds if called on an address that is already granted.
Calling grantBeta() multiple times on the same address causes the contract to emit BetaRevoked and BetaGranted events unnecessarily. This might lead to bugs in services listening to those events.
Although not recommended in the report, I would consider panicking the grantBeta() if the address is already granted.
liobrasil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_cleanupExistingGrantfunction that deletes old capability controllers before issuing new onesgrantBeta()before creating a new capabilityThis prevents storage bloat and maintains an accurate audit trail when
grantBeta()is called for an address that already has beta access.Quantstamp Audit Finding
FLOW-5: GrantBeta Overwrites Existing Capability without Cleanup (Low)
When
grantBeta()is called for an address that already has beta access, the function was creating a new capability and overwriting the entry inissuedCapIDswithout deleting the old capability controller.Test plan
grantBeta()twice for the same address properly cleans up the old capabilityBetaRevokedevent is emitted when cleaning up old capabilityCloses #136
🤖 Generated with Claude Code