add ssl_domains and host_vars for data1.htz-fsn.prod.ooni.io#435
Merged
Conversation
deploy-clickhouse.yml included dehydrated which didn't have the ssl_domains set for airflow.prod.ooni.io; adding this in host_vars ensures that includes of this module always obtain all the certificates.
Ansible Run Output 🤖Ansible Playbook Recap 🔍Ansible playbook output 📖
|
| Pusher | @aagbsn |
| Action | pull_request |
| Working Directory | |
| Workflow | .github/workflows/check_ansible.yml |
| Last updated | Mon, 25 May 2026 15:17:50 GMT |
dehydrated creates certificates in path /var/lib/dehydrated/ {{
ssl_hostname }} which means using {{ inventory_hostname }} picks the
wrong certificate. I'm not sure how this was working before
Contributor
Author
|
I also noticed the nginx template for airflow uses {{ inventory_hostname }} to specify the certificate path; dehydrated creates this in a path that uses the certificate hostname; and the deploy-airflow playbook 'hosts' specifies data1.htz-fsn.prod.ooni.nu so I'm not sure how this was working before. |
LDiazN
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy-clickhouse.yml included dehydrated which didn't have airflow.prod.ooni.io in ssl_domains (by default it uses inventory_hostname); adding this in host_vars ensures that includes of this module always obtain all the certificates.