Add PN and update board revision in print_report - #58
Open
cjsha wants to merge 6 commits into
Open
Conversation
- board_rev & gear_ratio are variables related to external hardware configuration - with this commit, these variables survive firmware flashes
Member
Author
|
This is a bit beyond the original scope of the PR. This loads firmware + hardware config variables (board revision and gear ratio) to two separate parts of the EEPROM. The benefits are:
|
earlier versions of picotool fail in the flash-utility.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #57
commit 50bca1e
The original issue suggested adding a "PID" field. This field name felt a bit ambiguous to me.
I opted for
{"part_number":"OEPS-7758"}instead, but feel free to overwrite.I also updated the Board Revision in the firmware because we're on revision J, not H. With that said, what is our standard practice documenting hardware revision within gateware/firmware?