Skip to content

[CODE HEALTH] Fix clang-tidy bugprone-exception-escape in sum_aggregation.cc #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcalff merged 4 commits into from
Jun 5, 2026
Merged

[CODE HEALTH] Fix clang-tidy bugprone-exception-escape in sum_aggregation.cc #4109

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
671202e
Update get to get_if to fix bugprone-exception-escape clangtidy error
jensecrest May 28, 2026
c57175b
Merge branch 'main' into clangtidy-exceptionesc-sumagg
jensecrest May 28, 2026
6e02712
Merge branch 'main' into clangtidy-exceptionesc-sumagg
ThomsonTan Jun 4, 2026
0d388cb
Merge branch 'main' into clangtidy-exceptionesc-sumagg
marcalff Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 80 additions & 24 deletions sdk/src/metrics/aggregation/sum_aggregation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,25 +45,53 @@ void LongSumAggregation::Aggregate(int64_t value, const PointAttributes & /* att

std::unique_ptr<Aggregation> LongSumAggregation::Merge(const Aggregation &delta) const noexcept
{
int64_t merge_value =
nostd::get<int64_t>(
nostd::get<SumPointData>((static_cast<const LongSumAggregation &>(delta).ToPoint()))
.value_) +
nostd::get<int64_t>(nostd::get<SumPointData>(ToPoint()).value_);
auto delta_point = static_cast<const LongSumAggregation &>(delta).ToPoint();
auto curr_point = ToPoint();

const auto *delta_sum = nostd::get_if<SumPointData>(&delta_point);
const auto *curr_sum = nostd::get_if<SumPointData>(&curr_point);
if (delta_sum == nullptr || curr_sum == nullptr)
{
OTEL_INTERNAL_LOG_ERROR("LongSumAggregation::Merge - Loss of type");
return std::unique_ptr<Aggregation>(new LongSumAggregation(point_data_.is_monotonic_));
}

const auto *delta_val = nostd::get_if<int64_t>(&delta_sum->value_);
const auto *curr_val = nostd::get_if<int64_t>(&curr_sum->value_);
if (delta_val == nullptr || curr_val == nullptr)
{
OTEL_INTERNAL_LOG_ERROR("LongSumAggregation::Merge - Loss of type");
return std::unique_ptr<Aggregation>(new LongSumAggregation(point_data_.is_monotonic_));
}

std::unique_ptr<Aggregation> aggr(new LongSumAggregation(point_data_.is_monotonic_));
static_cast<LongSumAggregation *>(aggr.get())->point_data_.value_ = merge_value;
static_cast<LongSumAggregation *>(aggr.get())->point_data_.value_ = *delta_val + *curr_val;
return aggr;
}

std::unique_ptr<Aggregation> LongSumAggregation::Diff(const Aggregation &next) const noexcept
{
int64_t diff_value =
nostd::get<int64_t>(
nostd::get<SumPointData>((static_cast<const LongSumAggregation &>(next).ToPoint()))
.value_) -
nostd::get<int64_t>(nostd::get<SumPointData>(ToPoint()).value_);
auto next_point = static_cast<const LongSumAggregation &>(next).ToPoint();
auto curr_point = ToPoint();

const auto *next_sum = nostd::get_if<SumPointData>(&next_point);
const auto *curr_sum = nostd::get_if<SumPointData>(&curr_point);
if (next_sum == nullptr || curr_sum == nullptr)
{
OTEL_INTERNAL_LOG_ERROR("LongSumAggregation::Diff - Loss of type");
return std::unique_ptr<Aggregation>(new LongSumAggregation(point_data_.is_monotonic_));
}

const auto *next_val = nostd::get_if<int64_t>(&next_sum->value_);
const auto *curr_val = nostd::get_if<int64_t>(&curr_sum->value_);
if (next_val == nullptr || curr_val == nullptr)
{
OTEL_INTERNAL_LOG_ERROR("LongSumAggregation::Diff - Loss of type");
return std::unique_ptr<Aggregation>(new LongSumAggregation(point_data_.is_monotonic_));
}

std::unique_ptr<Aggregation> aggr(new LongSumAggregation(point_data_.is_monotonic_));
static_cast<LongSumAggregation *>(aggr.get())->point_data_.value_ = diff_value;
static_cast<LongSumAggregation *>(aggr.get())->point_data_.value_ = *next_val - *curr_val;
return aggr;
}

Expand Down Expand Up @@ -98,25 +126,53 @@ void DoubleSumAggregation::Aggregate(double value,

std::unique_ptr<Aggregation> DoubleSumAggregation::Merge(const Aggregation &delta) const noexcept
{
double merge_value =
nostd::get<double>(
nostd::get<SumPointData>((static_cast<const DoubleSumAggregation &>(delta).ToPoint()))
.value_) +
nostd::get<double>(nostd::get<SumPointData>(ToPoint()).value_);
auto delta_point = static_cast<const DoubleSumAggregation &>(delta).ToPoint();
auto curr_point = ToPoint();

const auto *delta_sum = nostd::get_if<SumPointData>(&delta_point);
const auto *curr_sum = nostd::get_if<SumPointData>(&curr_point);
if (delta_sum == nullptr || curr_sum == nullptr)
{
OTEL_INTERNAL_LOG_ERROR("DoubleSumAggregation::Merge - Loss of type");
return std::unique_ptr<Aggregation>(new DoubleSumAggregation(point_data_.is_monotonic_));
}

const auto *delta_val = nostd::get_if<double>(&delta_sum->value_);
const auto *curr_val = nostd::get_if<double>(&curr_sum->value_);
if (delta_val == nullptr || curr_val == nullptr)
{
OTEL_INTERNAL_LOG_ERROR("DoubleSumAggregation::Merge - Loss of type");
return std::unique_ptr<Aggregation>(new DoubleSumAggregation(point_data_.is_monotonic_));
}

std::unique_ptr<Aggregation> aggr(new DoubleSumAggregation(point_data_.is_monotonic_));
static_cast<DoubleSumAggregation *>(aggr.get())->point_data_.value_ = merge_value;
static_cast<DoubleSumAggregation *>(aggr.get())->point_data_.value_ = *delta_val + *curr_val;
return aggr;
}

std::unique_ptr<Aggregation> DoubleSumAggregation::Diff(const Aggregation &next) const noexcept
{
double diff_value =
nostd::get<double>(
nostd::get<SumPointData>((static_cast<const DoubleSumAggregation &>(next).ToPoint()))
.value_) -
nostd::get<double>(nostd::get<SumPointData>(ToPoint()).value_);
auto next_point = static_cast<const DoubleSumAggregation &>(next).ToPoint();
auto curr_point = ToPoint();

const auto *next_sum = nostd::get_if<SumPointData>(&next_point);
const auto *curr_sum = nostd::get_if<SumPointData>(&curr_point);
if (next_sum == nullptr || curr_sum == nullptr)
{
OTEL_INTERNAL_LOG_ERROR("DoubleSumAggregation::Diff - Loss of type");
return std::unique_ptr<Aggregation>(new DoubleSumAggregation(point_data_.is_monotonic_));
}

const auto *next_val = nostd::get_if<double>(&next_sum->value_);
const auto *curr_val = nostd::get_if<double>(&curr_sum->value_);
if (next_val == nullptr || curr_val == nullptr)
{
OTEL_INTERNAL_LOG_ERROR("DoubleSumAggregation::Diff - Loss of type");
return std::unique_ptr<Aggregation>(new DoubleSumAggregation(point_data_.is_monotonic_));
}

std::unique_ptr<Aggregation> aggr(new DoubleSumAggregation(point_data_.is_monotonic_));
static_cast<DoubleSumAggregation *>(aggr.get())->point_data_.value_ = diff_value;
static_cast<DoubleSumAggregation *>(aggr.get())->point_data_.value_ = *next_val - *curr_val;
return aggr;
}

Expand Down
Loading