Skip to content

[CODE HEALTH] Move registry.cc propagator builders into anonymous namespace #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcalff merged 2 commits into from
Jun 4, 2026
+10 −2
Merged

[CODE HEALTH] Move registry.cc propagator builders into anonymous namespace #4121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ac2f3
[CODE HEALTH] Move registry.cc propagator builders into anonymous nam…
thc1006 Jun 4, 2026
d6e7146
Merge branch 'main' into codehealth/registry-internal-linkage
marcalff Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/clang-tidy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
matrix:
include:
- cmake_options: all-options-abiv1-preview
warning_limit: 371
warning_limit: 366
- cmake_options: all-options-abiv2-preview
warning_limit: 377
warning_limit: 372
env:
CC: /usr/bin/clang-22
CXX: /usr/bin/clang++-22
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ Increment the:
* [CODE HEALTH] Move simple_log_record_processor_test into anonymous namespace
[#4116](https://github.com/open-telemetry/opentelemetry-cpp/pull/4116)

* [CODE HEALTH] Move registry.cc propagator builders into anonymous namespace
[#4121](https://github.com/open-telemetry/opentelemetry-cpp/pull/4121)

## [1.27.0] 2026-05-13

* [RELEASE] Bump main branch to 1.27.0-dev
Expand Down
5 changes: 5 additions & 0 deletions sdk/src/configuration/registry.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ namespace sdk
namespace configuration
{

namespace
{

class TraceContextBuilder : public TextMapPropagatorBuilder
{
public:
Expand Down Expand Up @@ -77,6 +80,8 @@ class JaegerBuilder : public TextMapPropagatorBuilder
}
};

} // namespace

Registry::Registry()
{
SetTextMapPropagatorBuilder("tracecontext", std::make_unique<TraceContextBuilder>());
Expand Down
Loading