Skip to content

[CODE HEALTH] Move sdk_builder.cc builders into anonymous namespace #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcalff merged 1 commit into from
Jun 5, 2026
+10 −2
Merged

[CODE HEALTH] Move sdk_builder.cc builders into anonymous namespace #4122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/clang-tidy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
matrix:
include:
- cmake_options: all-options-abiv1-preview
warning_limit: 366
warning_limit: 356
- cmake_options: all-options-abiv2-preview
warning_limit: 372
warning_limit: 362
env:
CC: /usr/bin/clang-22
CXX: /usr/bin/clang++-22
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ Increment the:
* [CODE HEALTH] Move registry.cc propagator builders into anonymous namespace
[#4121](https://github.com/open-telemetry/opentelemetry-cpp/pull/4121)

* [CODE HEALTH] Move sdk_builder.cc builders into anonymous namespace
[#4122](https://github.com/open-telemetry/opentelemetry-cpp/pull/4122)

## [1.27.0] 2026-05-13

* [RELEASE] Bump main branch to 1.27.0-dev
Expand Down
5 changes: 5 additions & 0 deletions sdk/src/configuration/sdk_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ namespace configuration

using common::WildcardMatch;

namespace
{

class ResourceAttributeValueSetter
: public opentelemetry::sdk::configuration::AttributeValueConfigurationVisitor
{
Expand Down Expand Up @@ -747,6 +750,8 @@ class LogRecordExporterBuilder
const SdkBuilder *sdk_builder_;
};

} // namespace

std::unique_ptr<opentelemetry::sdk::trace::Sampler> SdkBuilder::CreateAlwaysOffSampler(
const opentelemetry::sdk::configuration::AlwaysOffSamplerConfiguration * /* model */) const
{
Expand Down
Loading