Skip to content

[CODE HEALTH] Move func_grpc_main classes into anonymous namespace #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcalff merged 1 commit into from
Jun 6, 2026
+10 −2
Merged

[CODE HEALTH] Move func_grpc_main classes into anonymous namespace #4129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/clang-tidy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
matrix:
include:
- cmake_options: all-options-abiv1-preview
warning_limit: 349
warning_limit: 346
- cmake_options: all-options-abiv2-preview
warning_limit: 353
warning_limit: 350
env:
CC: /usr/bin/clang-22
CXX: /usr/bin/clang++-22
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ Increment the:
* [CODE HEALTH] Move func_http_main classes into anonymous namespace
[#4128](https://github.com/open-telemetry/opentelemetry-cpp/pull/4128)

* [CODE HEALTH] Move func_grpc_main classes into anonymous namespace
[#4129](https://github.com/open-telemetry/opentelemetry-cpp/pull/4129)

## [1.27.0] 2026-05-13

* [RELEASE] Bump main branch to 1.27.0-dev
Expand Down
5 changes: 5 additions & 0 deletions functional/otlp/func_grpc_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ static std::string opt_cert_dir;
static std::string opt_test_name;
static TestMode opt_mode = TestMode::kNone;

namespace
{

/*
Log parsing
*/
Expand Down Expand Up @@ -319,6 +322,8 @@ struct test_case
test_func_t m_func;
};

} // namespace

static int test_basic();

static int test_cert_not_found();
Expand Down
Loading