[dynamic control] fix incorrectly special case parsing

[jackshirazi]

Description:

There was a special case parsing in OpampPolicyProvider, if ( ... format == SourceFormat.JSONKEYVALUE), on reviewing the code this clearly shouldn't be there, any parsing should exist within the format parsing and the provider should delegate all cases to there. This PR fixes this code smell.

Note the LinePerPolicyFileProvider.java and the keyvalue format are not fully implemented for now, they're pending later changes when the file provider is more fully specified

Existing Issue(s):

#2868

Testing:

changed as needed

Documentation:

not needed for this tech debt fix

Outstanding items:

#2868

[Copilot]

Pull request overview

This PR refactors dynamic-control policy payload parsing so providers always delegate parsing to SourceFormat (removing an OpAMP-specific JSON parsing fallback), and updates the JSON parsing path to validate policy IDs against configured mappings.

Changes:

• Extend SourceFormat.parse / JsonSourceWrapper.parse to accept a mappedPolicyIds set and use it during parsing (JSONKEYVALUE).
• Remove OpampPolicyProvider’s JSONKEYVALUE special-case parsing logic and delegate parsing solely to SourceFormat.
• Update unit tests and the file-based provider to pass mapped/allowed policy IDs into the parser.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/source/SourceFormat.java	Changes the parsing API to require mapped policy IDs and dispatches parsing with that context.
dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/source/JsonSourceWrapper.java	Updates JSON parsing to validate JSON object keys against configured mapped policy IDs.
dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/OpampPolicyProvider.java	Removes OpAMP-only JSONKEYVALUE fallback parsing and delegates parsing to SourceFormat.
dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/LinePerPolicyFileProvider.java	Computes allowed policy IDs from validators and passes them into SourceFormat.parse.
dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/policy/source/SourceFormatTest.java	Updates tests for the new parse signature + adds coverage for rejecting unmapped JSON keys.
dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/policy/source/JsonSourceWrapperTest.java	Updates tests for the new parse signature + adds coverage for rejecting unmapped JSON keys.
dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/policy/tracesampling/TraceSamplingValidatorTest.java	Updates tests to provide mapped policy IDs when parsing source text.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[jaydeluca]

i think we lose some safety here in terms of rejecting objects with more than 1 item. Take a look at jackshirazi#1